Allow skipping the tls check for webhooks #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkoenig134
requested review from
sebbi08,
slavistan,
stnmtz,
tnotheis and
Milena-Czierlinski
jkoenig134
changed the title
tnotheis
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some points it can be that services run under a self signed certificate. The only option at the moment is to turn of certificate validation globally using the
NODE_TLS_REJECT_UNAUTHORIZEDenvironment variable which also disables the tls check when accessing the backbone.Now it is possible to disable tls checks for the webhooks module.
Readiness checklist