Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DatawalletSynchronizedEvent is not anymore emitted in the connector #347

Merged
merged 8 commits into from
Jan 15, 2025
Merged

DatawalletSynchronizedEvent is not anymore emitted in the connector #347

merged 8 commits into from
Jan 15, 2025

Conversation

sebbi08
Copy link
Contributor

@sebbi08 sebbi08 commented Jan 15, 2025 •
edited
Loading

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.
  • I self-reviewed the PR.

@sebbi08 sebbi08 added the dependencies Pull requests that update dependencies label Jan 15, 2025
@sebbi08 sebbi08 requested a review from jkoenig134 January 15, 2025 10:17
@codecov Codecov
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

see 1 file with indirect coverage changes

jkoenig134
jkoenig134 reviewed Jan 15, 2025
View reviewed changes
test/lib/testUtils.ts Outdated Show resolved Hide resolved
@jkoenig134
Copy link
Member

This PR should be flagged as a bugfix as it fixes:

  • preventing of creation of duplicate repository attributes
  • DatawalletSynchronizedEvent is not anymore emitted in the connector

I'd put the second one in the title.

@jkoenig134
Copy link
Member

I general you should have bumped FIRST to 21, then to 23. The combination is not good for the changelog.

@jkoenig134
Copy link
Member

This PR should be flagged as a bugfix as it fixes:

  • preventing of creation of duplicate repository attributes
  • DatawalletSynchronizedEvent is not anymore emitted in the connector

I'd put the second one in the title.

@sebbi08 I'll not approve this until the release issues are resolved.

@sebbi08 sebbi08 changed the title Update runtime to version 6.23.0 DatawalletSynchronizedEvent is not anymore emitted in the connector Jan 15, 2025
@sebbi08 sebbi08 added bug Something isn't working and removed dependencies Pull requests that update dependencies labels Jan 15, 2025
@sebbi08 sebbi08 requested a review from jkoenig134 January 15, 2025 11:44
jkoenig134
jkoenig134 previously approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@jkoenig134 jkoenig134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

britsta
britsta reviewed Jan 15, 2025
View reviewed changes
test/lib/testUtils.ts Outdated Show resolved Hide resolved
britsta
britsta approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@britsta britsta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

@sebbi08 sebbi08 enabled auto-merge (squash) January 15, 2025 13:27
@sebbi08 sebbi08 merged commit abc25ed into main Jan 15, 2025
8 checks passed
@sebbi08 sebbi08 deleted the feature/runtime_update branch January 15, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkoenig134 jkoenig134 jkoenig134 left review comments

@britsta britsta britsta approved these changes

@Milena-Czierlinski Milena-Czierlinski Awaiting requested review from Milena-Czierlinski

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebbi08 @jkoenig134 @britsta