Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow lengthOfGracePeriodInDays to be set in debug API #349

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Allow lengthOfGracePeriodInDays to be set in debug API #349

merged 4 commits into from
Jan 16, 2025

Conversation

sebbi08
Copy link
Contributor

@sebbi08 sebbi08 commented Jan 16, 2025 •
edited
Loading

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.
  • I self-reviewed the PR.

@sebbi08 sebbi08 added the enhancement New feature or request label Jan 16, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
...g-controllers/IdentityDeletionProcessController.ts 100.00% <100.00%> (ø)

@jkoenig134
Copy link
Member

I ensured that the PR title is good enough for the changelog.

please treat this as a actual task - and not just tick it.

@sebbi08 sebbi08 changed the title chore: allow lengthOfGracePeriodInDays to be set in debug api Allow lengthOfGracePeriodInDays to be set in debug API Jan 16, 2025
@sebbi08
Copy link
Contributor Author

sebbi08 commented Jan 16, 2025

I ensured that the PR title is good enough for the changelog.

please treat this as a actual task - and not just tick it.

Weird I did that but somehow got not taken over :/

@sebbi08 sebbi08 enabled auto-merge (squash) January 16, 2025 08:02
@sebbi08 sebbi08 disabled auto-merge January 16, 2025 08:06
@jkoenig134 jkoenig134 merged commit 88270d2 into main Jan 16, 2025
8 checks passed
@jkoenig134 jkoenig134 deleted the feature/allow_setting_lengthOfGracePeriodInDays_for_debug_api branch January 16, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@britsta britsta britsta approved these changes

@jkoenig134 jkoenig134 jkoenig134 approved these changes

@Milena-Czierlinski Milena-Czierlinski Awaiting requested review from Milena-Czierlinski

@Magnus-Kuhn Magnus-Kuhn Awaiting requested review from Magnus-Kuhn

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebbi08 @jkoenig134 @britsta