[coverity] fix un-initialization issues

fixed some un-unitialization issues **Self evaluation:** Build test: [x]Passed [ ]Failed [ ]Skipped Run test: [x]Passed [ ]Failed [ ]Skipped Signed-off-by: Seungbaek Hong <[email protected]>
nnstreamer · Feb 12, 2025 · f37f93c · f37f93c
1 parent df8444a
commit f37f93c
Show file tree

Hide file tree

Showing 9 changed files with 25 additions and 11 deletions.
diff --git a/nntrainer/graph/network_graph.h b/nntrainer/graph/network_graph.h
@@ -51,7 +51,9 @@ class NetworkGraph {
     optimize_memory(true),
     exec_mode(ExecutionMode::TRAIN),
     tensor_format("NCHW"),
-    tensor_dtype(split("FP32-FP32", getRegex("\\-"))) {
+    tensor_dtype(split("FP32-FP32", getRegex("\\-"))),
+    is_clip_grad(false),
+    loss_scale(1.0f) {
     nan_count = 0;
   }
 
@@ -80,7 +82,9 @@ class NetworkGraph {
     optimize_memory(true),
     exec_mode(mode),
     tensor_format(tensor_format_),
-    tensor_dtype(split(tensor_dtype_, getRegex("\\-"))) {
+    tensor_dtype(split(tensor_dtype_, getRegex("\\-"))),
+    is_clip_grad(false),
+    loss_scale(1.0f) {
     nan_count = 0;
   }
 

diff --git a/nntrainer/layers/layer_node.cpp b/nntrainer/layers/layer_node.cpp
@@ -229,7 +229,8 @@ LayerNode::LayerNode(std::unique_ptr<nntrainer::Layer> &&l) :
   loss(new props::Loss()),
   regularization_loss(0.0f),
   exec_order({0, 0, 0, 0}),
-  needs_restore_data(false) {
+  needs_restore_data(false),
+  data_type({TensorDim::DataType::FP32, TensorDim::DataType::FP32}) {
   if (layer && layer->getType() == TimeDistLayer::type) {
     std::get<props::Distribute>(*layer_node_props).set(true);
   }

diff --git a/nntrainer/tensor/char_tensor.cpp b/nntrainer/tensor/char_tensor.cpp
@@ -18,7 +18,7 @@
 namespace nntrainer {
 
 CharTensor::CharTensor(std::string name_, Tformat fm, QScheme qscheme_) :
-  TensorBase(name_, fm, Tdatatype::QINT8) {}
+  TensorBase(name_, fm, Tdatatype::QINT8), qscheme(qscheme_) {}
 
 CharTensor::CharTensor(const TensorDim &d, bool alloc_now, Initializer init,
                        std::string name, QScheme qscheme_) :

diff --git a/nntrainer/tensor/char_tensor.h b/nntrainer/tensor/char_tensor.h
@@ -68,7 +68,8 @@ class CharTensor : public TensorBase {
    * @brief Construct a new CharTensor object
    * @param rhs TensorBase object to copy
    */
-  CharTensor(TensorBase &rhs) : TensorBase(rhs) {}
+  CharTensor(TensorBase &rhs) :
+    TensorBase(rhs), qscheme(QScheme::PER_TENSOR_AFFINE) {}
 
   /**
    * @brief Basic Destructor

diff --git a/nntrainer/tensor/int4_tensor.cpp b/nntrainer/tensor/int4_tensor.cpp
@@ -18,7 +18,7 @@
 namespace nntrainer {
 
 Int4QTensor::Int4QTensor(std::string name_, Tformat fm, QScheme qscheme_) :
-  TensorBase(name_, fm, Tdatatype::QINT4) {}
+  TensorBase(name_, fm, Tdatatype::QINT4), qscheme(qscheme_) {}
 
 Int4QTensor::Int4QTensor(const TensorDim &d, bool alloc_now, Initializer init,
                          std::string name, QScheme qscheme_) :
@@ -339,7 +339,7 @@ std::vector<unsigned int> Int4QTensor::argmax() const {
 
   for (unsigned int b = 0; b < batch_size; ++b) {
     int8_t curr_val, max_val = -8;
-    unsigned int max_element_idx;
+    unsigned int max_element_idx = 0;
     for (unsigned int idx = 0; idx < feature_len; ++idx) {
       curr_val = getValue(idx + b * feature_len);
 

diff --git a/nntrainer/tensor/int4_tensor.h b/nntrainer/tensor/int4_tensor.h
@@ -74,7 +74,8 @@ class Int4QTensor : public TensorBase {
    * @brief Construct a new Int4QTensor object
    * @param rhs TensorBase object to copy
    */
-  Int4QTensor(TensorBase &rhs) : TensorBase(rhs) {}
+  Int4QTensor(TensorBase &rhs) :
+    TensorBase(rhs), qscheme(QScheme::PER_TENSOR_AFFINE) {}
 
   /**
    * @brief Basic Destructor

diff --git a/nntrainer/tensor/quantizer.h b/nntrainer/tensor/quantizer.h
@@ -244,7 +244,12 @@ class PerChannelAffineQuantizer : public UniformQuantizer {
   /**
    * @brief Basic Constructor of a PerChannelAffineQuantizer
    */
-  PerChannelAffineQuantizer() : UniformQuantizer() {}
+  PerChannelAffineQuantizer() :
+    UniformQuantizer(),
+    scales(nullptr),
+    zero_points(nullptr),
+    quant_min(0),
+    quant_max(0) {}
 
   /**
    * @copydoc Quantizer::create()

diff --git a/nntrainer/tensor/short_tensor.h b/nntrainer/tensor/short_tensor.h
@@ -61,7 +61,8 @@ class ShortTensor : public TensorBase {
    * @brief Construct a new ShortTensor object
    * @param rhs TensorBase object to copy
    */
-  ShortTensor(TensorBase &rhs) : TensorBase(rhs) {}
+  ShortTensor(TensorBase &rhs) :
+    TensorBase(rhs), qscheme(QScheme::PER_TENSOR_AFFINE) {}
 
   /**
    * @brief Basic Destructor

diff --git a/nntrainer/tensor/uint_tensor.h b/nntrainer/tensor/uint_tensor.h
@@ -69,7 +69,8 @@ template <typename T> class UIntTensor : public TensorBase {
    * @brief Construct a new UIntTensor object
    * @param rhs TensorBase object to copy
    */
-  UIntTensor(TensorBase &rhs) : TensorBase(rhs) {}
+  UIntTensor(TensorBase &rhs) :
+    TensorBase(rhs), qscheme(QScheme::PER_TENSOR_AFFINE) {}
 
   /**
    * @brief Basic Destructor