[refactoring] add withKey function to utility functions @open sesame 02/21 08:59 #2954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baek2sm
requested review from
myungjoo,
jijoongmoon,
again4you,
jaeyun-jung,
leemgs,
wooksong,
gichan-jang,
anyj0527,
lhs8928,
songgot,
jihochu,
DonghakPark,
SeoHyungjun,
skykongkong8,
djeong20,
EunjuYang,
dkjung and
haehun
as code owners
skykongkong8
approved these changes
Feb 18, 2025
baek2sm
force-pushed
the
util_withkey
branch
from
d9646f1 to
4686f13
Compare
baek2sm
changed the title
baek2sm
changed the title
|
@baek2sm Could you rebase? |
The `withKey` function is frequently used to pass keys and values when using nntrainer. however, this function is re-defined in every application example and unit test, resulting in significant code duplication within the project(moreover, it is inconvenient because users of nntrainer have to define this function every time) So I removed the duplicated `withKey` functions from each script and added `withKey` function to utility functions. **Self evaluation:** Build test: [x]Passed [ ]Failed [ ]Skipped Run test: [x]Passed [ ]Failed [ ]Skipped Signed-off-by: Seungbaek Hong <[email protected]>
|
@dkjung It's done. thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
withKeyfunction is frequently used to pass keys and values whenusing nntrainer. however, this function is re-defined in every
application example and unit test, resulting in significant code
duplication within the project(moreover, it is inconvenient because
users of nntrainer have to define this function every time)
So I removed the duplicated
withKeyfunctions from each script andadded
withKeyfunction to utility functions.Self evaluation:
Build test: [x]Passed [ ]Failed [ ]Skipped
Run test: [x]Passed [ ]Failed [ ]Skipped
Signed-off-by: Seungbaek Hong [email protected]