Add GraphNodeIterator::operator<= required by std::reverse_iterator #2955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrrak
requested review from
myungjoo,
jijoongmoon,
again4you,
jaeyun-jung,
leemgs,
wooksong,
gichan-jang,
anyj0527,
lhs8928,
songgot,
jihochu,
DonghakPark,
SeoHyungjun,
baek2sm,
skykongkong8,
djeong20,
EunjuYang,
dkjung and
haehun
as code owners
myungjoo
reviewed
Feb 18, 2025
nntrainer/graph/graph_node.h
Outdated
| @@ -193,6 +193,19 @@ class GraphNodeIterator { | |||
| return lhs.p != rhs.p; | |||
| } | |||
|
|
|||
| /** | |||
| * @brief != comparison operator override | |||
|
Please check if all your commits are correctly signed-off |
piotrrak
force-pushed
the
cpp_debugstl_fix
branch
from
9e7124b to
b04fe2f
Compare
djeong20
approved these changes
Feb 21, 2025
piotrrak
force-pushed
the
cpp_debugstl_fix
branch
from
14fb9e6 to
b768b45
Compare
myungjoo
approved these changes
Mar 7, 2025
|
The CI error is about "no commit message" (the 1st commit has an empty commit message) |
|
This is a trivial PR. Please do squash, amend commit message, push, and merge and move on. |
piotrrak
force-pushed
the
cpp_debugstl_fix
branch
from
b768b45 to
edb1d83
Compare
…dapter This makes possible to build nntrainer in standard library debug mode. Please see: https://gcc.gnu.org/onlinedocs/libstdc++/manual/debug_mode.html Signed-off-by: Piotr Rak <[email protected]>
piotrrak
force-pushed
the
cpp_debugstl_fix
branch
from
edb1d83 to
90b98bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it is not technically used by normal build its presence is verified during debug standard library build.
More info about debug mode of standard library: https://gcc.gnu.org/onlinedocs/libstdc++/manual/debug_mode.html