Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Add Windows CI #2991

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gkisalapl
Copy link
Contributor

@gkisalapl gkisalapl commented Mar 6, 2025

This PR add running continues integration build of nntrainer on Windows
Tests are turn off for now since two test cases failed on Windows

Self-evaluation:

  1. Build test: [X]Passed [ ]Failed [ ]Skipped
  2. Run test: [X]Passed [ ]Failed [ ]Skipped

@gkisalapl gkisalapl force-pushed the add_windows_ci branch 2 times, most recently from 5e0e10e to 9284c77 Compare March 6, 2025 09:35
@gkisalapl gkisalapl force-pushed the add_windows_ci branch 2 times, most recently from 20a97b4 to 695168e Compare March 6, 2025 10:10
@gkisalapl gkisalapl changed the title [Windows] Add windows CI [Windows] Add windows CI [depends on #2987] Mar 6, 2025
@gkisalapl gkisalapl marked this pull request as ready for review March 6, 2025 10:11
@skykongkong8
Copy link
Member

Try rebase. #2897 is merged.

Copy link
Member

@DonghakPark DonghakPark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!~

@myungjoo
Copy link
Member

myungjoo commented Mar 7, 2025

Please rebase to #2987 and see if it fixes the compiler errors.

@dkjung
Copy link
Collaborator

dkjung commented Mar 7, 2025

@gkisalapl Windows build seems to fail. Could you check?

@dkjung
Copy link
Collaborator

dkjung commented Mar 7, 2025

FAILED: nntrainer/nntrainer.dll.p/D__a_nntrainer_nntrainer_nntrainer_tensor_cpu_backend_x86_avx2_impl.cpp.obj 
"cl" "-Inntrainer\nntrainer.dll.p" "-Inntrainer" "-I..\nntrainer" "-Iapi" "-I..\api" "-I..\api\ccapi\include" "-Inntrainer\compiler" "-I..\nntrainer\compiler" "-Inntrainer\schema" "-I..\nntrainer\schema" "-Inntrainer\dataset" "-I..\nntrainer\dataset" "-Inntrainer\layers\loss" "-I..\nntrainer\layers\loss" "-Inntrainer\layers" "-I..\nntrainer\layers" "-Inntrainer\models" "-I..\nntrainer\models" "-Inntrainer\optimizers" "-I..\nntrainer\optimizers" "-Inntrainer\tensor\cpu_backend\fallback" "-I..\nntrainer\tensor\cpu_backend\fallback" "-Inntrainer\tensor\cpu_backend\cblas_interface" "-I..\nntrainer\tensor\cpu_backend\cblas_interface" "-Inntrainer\tensor\cpu_backend\x86" "-I..\nntrainer\tensor\cpu_backend\x86" "-Inntrainer\tensor\cpu_backend" "-I..\nntrainer\tensor\cpu_backend" "-Inntrainer\tensor" "-I..\nntrainer\tensor" "-Inntrainer\utils" "-I..\nntrainer\utils" "-Inntrainer\graph" "-I..\nntrainer\graph" "-Isubprojects\OpenBLAS\__CMake_build" "-I..\subprojects\OpenBLAS\__CMake_build" "-Isubprojects\OpenBLAS" "-I..\subprojects\OpenBLAS" "-I..\subprojects\iniparser\src" "-Isubprojects\iniparser\__CMake_build" "-I..\subprojects\iniparser\__CMake_build" "-Isubprojects\iniparser" "-I..\subprojects\iniparser" "-Isubprojects\ruy" "-I..\subprojects\ruy" "-I..\subprojects\ruy\third_party\cpuinfo\include" "-I..\subprojects\ruy\third_party\cpuinfo\deps\clog\include" "-Isubprojects\ruy\__CMake_build" "-I..\subprojects\ruy\__CMake_build" "/MD" "/nologo" "/showIncludes" "/utf-8" "/Zc:__cplusplus" "/W2" "/EHsc" "/std:c++20" "/permissive-" "/O2" "/Gw" "/MT" "-DVERSION=\"0.6.0\"" "-DVERSION_MAJOR=0" "-DVERSION_MINOR=6" "-DVERSION_MICRO=0" "/arch:AVX2" "-DMIN_CPP_VERSION=201703L" "-DOPENCL_KERNEL_PATH=nntrainer_opencl_kernels" "-DML_API_COMMON=0" "-DUSE_BLAS=1" "-DHGEMM_EXPERIMENTAL_KERNEL=false" "-DNNTR_NUM_THREADS=1" "-DOMP_NUM_THREADS=1" "-D__LOGGING__=1" "-DENABLE_TEST=1" "-DREDUCE_TOLERANCE=1" "-DNNTRAINER_CONF_PATH=\"c:/etc/nntrainer.ini\"" "/openmp" "/Fdnntrainer\nntrainer.dll.p\D__a_nntrainer_nntrainer_nntrainer_tensor_cpu_backend_x86_avx2_impl.cpp.pdb" /Fonntrainer/nntrainer.dll.p/D__a_nntrainer_nntrainer_nntrainer_tensor_cpu_backend_x86_avx2_impl.cpp.obj "/c" D:/a/nntrainer/nntrainer/nntrainer/tensor/cpu_backend/x86/avx2_impl.cpp
cl : Command line warning D9025 : overriding '/MD' with '/MT'
D:/a/nntrainer/nntrainer/nntrainer/tensor/cpu_backend/x86/avx2_impl.cpp(31): error C2039: 'numeric_limits': is not a member of 'std'
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.43.34808\include\cmath(1164): note: see declaration of 'std'
D:/a/nntrainer/nntrainer/nntrainer/tensor/cpu_backend/x86/avx2_impl.cpp(31): error C2062: type 'float' unexpected
D:/a/nntrainer/nntrainer/nntrainer/tensor/cpu_backend/x86/avx2_impl.cpp(31): error C2039: 'infinity': is not a member of '`global namespace''
D:/a/nntrainer/nntrainer/nntrainer/tensor/cpu_backend/x86/avx2_impl.cpp(90): error C2039: 'numeric_limits': is not a member of 'std'
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.43.34808\include\cmath(1164): note: see declaration of 'std'
D:/a/nntrainer/nntrainer/nntrainer/tensor/cpu_backend/x86/avx2_impl.cpp(90): error C2062: type 'float' unexpected
D:/a/nntrainer/nntrainer/nntrainer/tensor/cpu_backend/x86/avx2_impl.cpp(90): error C2039: 'infinity': is not a member of '`global namespace''
D:/a/nntrainer/nntrainer/nntrainer/tensor/cpu_backend/x86/avx2_impl.cpp(90): error C2143: syntax error: missing ';' before '{'
[2285/2601] Compiling C++ object nntrainer/nntrainer.dll.p/D__a_nntrainer_nntrainer_nntrainer_optimizers_optimizer_wrapped.cpp.obj

Copy link
Contributor

@EunjuYang EunjuYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please rebase it to check the CI result! 👍

Copy link
Collaborator

@dkjung dkjung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Windows build seems to fail. Could you check?

This PR add running continues integration build of nntrainer on Windows
Tests are turn off for now since two test cases failed on Windows

**Self-evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test:   [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Grzegorz Kisala <[email protected]>
@gkisalapl
Copy link
Contributor Author

The Windows build seems to fail. Could you check?

It pass after rebase with #2987

@gkisalapl gkisalapl changed the title [Windows] Add windows CI [depends on #2987] [Windows] Add windows CI Mar 7, 2025
@gkisalapl gkisalapl changed the title [Windows] Add windows CI [Windows] Add Windows CI Mar 7, 2025
Copy link
Collaborator

@dkjung dkjung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkjung
Copy link
Collaborator

dkjung commented Mar 7, 2025

The Windows build seems to fail. Could you check?

It pass after rebase with #2987

I see

Copy link
Contributor

@baek2sm baek2sm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI for Windows! nice work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants