Update to CentOS 8 and support command-line arguments #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifireball
force-pushed
the
args-runner
branch
from
fc9a40e
to
1f3a4dc
Compare
1. Rebased the image on the fedora:31 image 2. Removed all env-var handling code as its basically superseded by the systemd `PassEnvironment` option that can be specified on a per-unit-file basis 3. Made systemd and journald output go to `/dev/console` which should be collected by the container engine automatically 4. Made a new service unit file that tries to run the arguments given to the container as commands after all systemd services have started and exit the container once those commands are done while returning an appropriate return value. 5. It is possible to have environment variables passed to the invoked commands by setting variable names in the `ARGS_ENV_INCLUDE` variable either when launching the container or when building derived containers Note: The CentOs version upgrade is required, among other things, because the `systemd` version in CentOS 7 does not support returning exit codes on exit. Note: Certain versions of Docker have an issue with collecting `/dev/console` properly. See the following for explanation: - systemd/systemd#4262 - moby/moby#27202 - https://bugzilla.redhat.com/show_bug.cgi?id=1373780 This image also include a workaround for the following Podman issue: - containers/podman#4625 Signed-off-by: Barak Korren <[email protected]>
ifireball
force-pushed
the
args-runner
branch
from
1f3a4dc
to
d7985cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hosts because their userspace tools only support
nftand notiptables. In Fedora we canstill install the legacy
iptablestoolssystemd
PassEnvironmentoption that can be specified on aper-unit-file basis
/dev/consolewhich should becollected by the container engine automatically
to the container as commands after all systemd services have started
and exit the container once those commands are done while returning
an appropriate return value.
commands by setting variable names in the
ARGS_ENV_INCLUDEvariableeither when launching the container or when building derived
containers
Note: The CentOs version upgrade is required, among other things,
because the
systemdversion in CentOS 7 does not support returningexit codes on exit.
Note: Certain versions of Docker have an issue with collecting
/dev/consoleproperly. See the following for explanation:Signed-off-by: Barak Korren [email protected]