Backport XSS Fixes #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have not quite found a solution for the "stuck focus" problem on current versions of Selectr (upstream).
As a temporary solution, I have backported the XSS fixes on top of our current branch. This includes upsream PRs Mobius1#100 Mobius1#120 and Mobius1#121 all of which were approved and merged to address this issue.
Tested against the PoC offered in https://nexcess.atlassian.net/browse/NSD-16851
Core currently pulls from the
nocworxbranch, so once merged here the fix will be brought into production on the next deploy.