Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Redesign release workflow #217

Merged
merged 5 commits into from
Dec 10, 2023
Merged

chore: Redesign release workflow #217

merged 5 commits into from
Dec 10, 2023

Conversation

rabe1028
Copy link
Contributor

@rabe1028 rabe1028 commented Dec 3, 2023

Why

  • We want to move our development process to GitHub Flow
  • Currently, our release pipeline is built for Git flow.

What

  • I redesigned the release workflow.
    • Creation of GitHub Releases can now be done from workflow_dispatch.

Ref

@rabe1028 rabe1028 requested a review from a team as a code owner December 3, 2023 16:44
@miseyu
Copy link
Contributor

miseyu commented Dec 4, 2023

@rabe1028
Thank you!
I have made a few comments, please check them out.

@miseyu
Copy link
Contributor

miseyu commented Dec 4, 2023

@rabe1028
I'd like to see some documentation added to the README or something on how to release it.

@miseyu
Copy link
Contributor

miseyu commented Dec 5, 2023

@rabe1028
[CONFIRMATION].
https://github.com/nodecross/nodex/blob/develop/.github/workflows/release-pipeline.yml
Do you need to remove the ?

If you are going to remove it,
If so, please change the release-pipeline badge in the README to release.

@rabe1028
Copy link
Contributor Author

rabe1028 commented Dec 5, 2023

@miseyu
Thanks. I removed it and changed the badge in README.

miseyu
miseyu approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@miseyu miseyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your support!
LGTM!!

@rabe1028 rabe1028 merged commit 6af4ad9 into main Dec 10, 2023
5 checks passed
@rabe1028 rabe1028 deleted the add-new-release-workflow branch December 10, 2023 13:21
@rabe1028 rabe1028 mentioned this pull request Dec 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miseyu miseyu miseyu approved these changes

Assignees

@rabe1028 rabe1028

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rabe1028 @miseyu