Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: display log time in rfc3339 #224

Merged
merged 1 commit into from
Feb 1, 2024
Merged

chore: display log time in rfc3339 #224

merged 1 commit into from
Feb 1, 2024

Conversation

rabe1028
Copy link
Contributor

Description

Currently, the agent uses a proprietary format for logging time.
However, this has no time zone, making it difficult to match the time of log to the time of the message.

To solve this, use RFC3339 format which has a timezone information.

Check

Before

2024-01-30T19:07:00 [ERROR] - nodex_agent::nodex::utils::hub_client - reqwest::Error { kind: Request, url: Url { scheme: "http", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("localhost")), port: Some(8000), path: "/v1/device", query: None, fragment: None }, source: hyper::Error(Connect, ConnectError("tcp connect error", Os { code: 61, kind: ConnectionRefused, message: "Connection refused" })) } - src/nodex/utils/hub_client.rs:106

After

2024-01-30T19:01:52.239393+09:00 [ERROR] - nodex_agent::nodex::utils::hub_client - reqwest::Error { kind: Request, url: Url { scheme: "http", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("localhost")), port: Some(8000), path: "/v1/device", query: None, fragment: None }, source: hyper::Error(Connect, ConnectError("tcp connect error", Os { code: 61, kind: ConnectionRefused, message: "Connection refused" })) } - src/nodex/utils/hub_client.rs:106

@rabe1028 rabe1028 requested a review from a team as a code owner January 30, 2024 10:10
Copy link
Contributor

@curry-like curry-like left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rabe1028 rabe1028 merged commit 5508740 into main Feb 1, 2024
5 checks passed
@rabe1028 rabe1028 deleted the use-rfc3339 branch February 1, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants