fix: Make the body of the error response into json #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3kz2501
previously approved these changes
Oct 6, 2024
ibuibu
force-pushed
the
chore/error-code
branch
from
f007e09
to
8fd770f
Compare
3kz2501
approved these changes
Oct 10, 2024
ibuibu
added a commit
that referenced
this pull request
Oct 20, 2024
tzskp1
added a commit
that referenced
this pull request
Oct 21, 2024
ibuibu
added a commit
that referenced
this pull request
Nov 4, 2024
* Reapply "fix: Make the body of the error response into json (#402)" (#408) This reverts commit 05317c3. * response error code as number * Make custom errors work. * Add empty check in create didcomm message * modify sock.py * Add empty check fo create vc message * add sys for sock.py * mod conflict message --------- Co-authored-by: Kazunari Tanaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change error response body to JSON.
The JSON consists of a message and an error code.