-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Alpine 3.19 variant #2007
Add Alpine 3.19 variant #2007
Conversation
Also set 3.19 as new default
we need to wait for docker-library/official-images#15852 |
Already merged. |
Created PR on the official-images repo (docker-library/official-images#15876). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub. |
This seems to have broken my builds - node-gyp can't find python anymore. I'll downgrade and test... Assuming its this though, as builds worked yesterday, before it was available and seems to have died today |
I can confirm that sticking to a previous tag here fixes the build. |
@wbecker we've never shipped python with Alpine https://github.com/nodejs/docker-node/blob/main/docs/BestPractices.md#node-gyp-alpine |
Thanks - I'll try this! However there seems to be some issues with some libs - I'll link the issue here: #2009 |
Description
This PR adds a variant for Alpine 3.19 and drops the 3.17 variant at the same time.
See also #1895.
Motivation and Context
Provide latest Alpine version (see https://alpinelinux.org/posts/Alpine-3.19.0-released.html).
Testing Details
Example Output(if appropriate)
Types of changes
Checklist
Note: the Alpine 3.19 base Docker image is yet to appear here, so automated checks will fail up till then; see also docker-library/official-images#15852.Edit: the Alpine 3.19 base images are now available, so this is now ready for a retrigger of the workflow!