Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Alpine 3.19 variant #2007

Merged
merged 2 commits into from
Dec 10, 2023
Merged

Add Alpine 3.19 variant #2007

merged 2 commits into from
Dec 10, 2023

Conversation

jnoordsij
Copy link
Contributor

@jnoordsij jnoordsij commented Dec 7, 2023

Description

This PR adds a variant for Alpine 3.19 and drops the 3.17 variant at the same time.
See also #1895.

Motivation and Context

Provide latest Alpine version (see https://alpinelinux.org/posts/Alpine-3.19.0-released.html).

Testing Details

Example Output(if appropriate)

Types of changes

  • Documentation
  • Version change (Update, remove or add more Node.js versions)
  • Variant change (Update, remove or add more variants, or versions of variants)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (none of the above)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • All new and existing tests passed.

Note: the Alpine 3.19 base Docker image is yet to appear here, so automated checks will fail up till then; see also docker-library/official-images#15852.

Edit: the Alpine 3.19 base images are now available, so this is now ready for a retrigger of the workflow!

@SimenB
Copy link
Member

SimenB commented Dec 7, 2023

we need to wait for docker-library/official-images#15852

@Earlopain
Copy link

Already merged.

@nschonni nschonni merged commit b1542f5 into nodejs:main Dec 10, 2023
11 checks passed
Copy link

Created PR on the official-images repo (docker-library/official-images#15876). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub.

@jnoordsij jnoordsij deleted the add-alpine-3.19 branch December 10, 2023 07:32
@wbecker
Copy link

wbecker commented Dec 12, 2023

This seems to have broken my builds - node-gyp can't find python anymore. I'll downgrade and test...

Assuming its this though, as builds worked yesterday, before it was available and seems to have died today

@wbecker
Copy link

wbecker commented Dec 12, 2023

I can confirm that sticking to a previous tag here fixes the build.

@nschonni
Copy link
Member

@wbecker
Copy link

wbecker commented Dec 13, 2023

Thanks - I'll try this! However there seems to be some issues with some libs - I'll link the issue here: #2009

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants