lenient_flags is truncated on reset #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guoye-zhang
commented
Sep 22, 2023
| @@ -126,7 +126,7 @@ void llhttp_reset(llhttp_t* parser) { | |||
| llhttp_type_t type = parser->type; | |||
| const llhttp_settings_t* settings = parser->settings; | |||
| void* data = parser->data; | |||
| uint8_t lenient_flags = parser->lenient_flags; | |||
| uint16_t lenient_flags = parser->lenient_flags; | |||
There was a problem hiding this comment.
Maybe it should be __typeof(parser->lenient_flags) since it could grow bigger in the future?
There was a problem hiding this comment.
Good point, but for now I wouldn't worry about it too much. It will take a lot for other 8 lenient flags to appear, I hope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer lenient flags
LENIENT_OPTIONAL_CR_BEFORE_LFLENIENT_SPACES_AFTER_CHUNK_SIZEare lost duringllhttp_reset