deps: fix typos across multiple files #57204
Open
+13
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
dependencies
jasnell
reviewed
Feb 25, 2025
| @@ -180,7 +180,7 @@ int32_t MlBreakEngine::initIndexList(const UnicodeString &inString, int32_t *ind | |||
| } | |||
| int32_t index = 0; | |||
| int32_t length = inString.countChar32(); | |||
| // Set all (lenght+4) items inside indexLength to -1 presuming -1 is 4 bytes of 0xff. | |||
There was a problem hiding this comment.
This fix would need to be made in the upstream dependency. This change should be removed from this PR.
jasnell
reviewed
Feb 25, 2025
| @@ -399,7 +399,7 @@ typedef struct ResourceData { | |||
| UBool useNativeStrcmp; | |||
| } ResourceData; | |||
|
|
|||
| struct UResourceDataEntry; // forward declared for ResoureDataValue below; actually defined in uresimp.h | |||
There was a problem hiding this comment.
This fix would need to be made in the upstream dependency. This change should be removed from this PR.
jasnell
reviewed
Feb 25, 2025
| @@ -46,7 +46,7 @@ typedef struct ngtcp2_log { | |||
| told. */ | |||
| ngtcp2_tstamp last_ts; | |||
| /* user_data is user-defined opaque data which is passed to | |||
| log_pritnf. */ | |||
There was a problem hiding this comment.
This fix would need to be made in the upstream dependency. This change should be removed from this PR.
jasnell
requested changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[deps] Fix typos across multiple files
This PR fixes minor typos in various dependency-related files.
These changes do not affect functionality and are limited to comments and documentation.
deps/icu-small,deps/ngtcp2, anddeps/v8.