deps: update ada to 3.1.2

[nodejs-github-bot]

This is an automated update of ada to 3.1.2.

[nodejs-github-bot]

Review requested:

• @nodejs/security-wg
• @nodejs/url

[anonrig]

../deps/ada/ada.h:9483:48: error: comparison of integers of different signs: 'const value_type' (aka 'const char') and 'uint32_t' (aka 'unsigned int') [-Werror,-Wsign-compare]
 9483 |   if (!token->value.empty() && token->value[0] != value) {
      |                                ~~~~~~~~~~~~~~~ ^  ~~~~~
      ```

@lemire it seems the latest release doesn't fix this... any ideas?

[anonrig]

@richardlau @nodejs/build @nodejs/url any suggestions on how to reproduce this on github.com/ada-url/ada?

[richardlau]

@richardlau @nodejs/build @nodejs/url any suggestions on how to reproduce this on github.com/ada-url/ada?

Have you tried the GH Ubuntu 24.04 runner with clang (apparently 18.1.3) and -Werror? Or macOS with Xcode 16.1 and -Werror?

[anonrig]

Have you tried the GH Ubuntu 24.04 runner with clang (apparently 18.1.3) and -Werror? Or macOS with Xcode 16.1 and -Werror?

I can't seem to reproduce.

[bricss]

AI 🤖 suggests 💡 an explicit type cast to fix the error 🫠 or change token value type 🤔

[anonrig]

AI 🤖 suggests 💡 an explicit type cast to fix the error 🫠 or change token value type 🤔

Without a reproduction on Ada's CI, it's extremely likely to regress.