-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed setupSandboxWithMinipools following errors caused by last merge #210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onstellation into feature/pull-model
pull model seems to work
* rpl vault update keeper Update WETHVault.sol Update OperatorDistributor.sol Update RPLVault.sol complete keeper * update tests * tests / rplTopDown / bug fix update Update WETHVault.sol Update WETHVault.sol update Update OperatorDistributor.sol Update OperatorDistributor.sol * good bot * update * add tests * add test * wed. bug fix + polish tests/polish update redeem success bug fixes Update test-xRpl.ts yeahhhhhhhhh Update test-xRpl.ts Update test-xRpl.ts Update test-xRpl.ts test rm debug update Update RPLVault.sol Update WETHVault.sol new test debug * Update WETHVault.sol update fix tests sanctions check on xreth xreth deposit works debug * tests and bug fixes bug fixes atomic fee bug symetric cchecks rm DOS vector * comments for teddy * fix tests * fully patch grief vector Update OperatorDistributor.sol * oracle fallback + rm hardcode optionality for using odao / uniswap rm redundancy / dynamic rpl max bonding * found bug fix test bug patch * patch Update gas-report.txt fix test fix tests bug fix bug fix fix test bug fix * typo * add docs * add docs rm comment * add docs * add comment * remove split redundancy * Update DepositPool.sol * rm all tests on dp * debug * Update WETHVault.sol * Revert "Update WETHVault.sol" This reverts commit 7b39f39. * it's all borked * debug + fix test * comments * Update OperatorDistributor.sol
add CI/CD tests add tests big test optimizations voting wrappers delegation wrappers merkle claim wrapper ✅ Set voting delegate (On-chain) ✅ Clear voting delegate (On-chain) ✅ Distribute Balance (Manual) ✅ Delegate upgrade ✅ Delegate rollback ✅ Set use latest delegate ✅ merkle claim keeper
* bug fix * break 20 tests * finish feature success * add comments
optimize oops
…atch (#159) * complete tasks * update * typo * update * rm beginUserDistribute * admin only * add docs
* safety redundancy * llint * Update RPLVault.sol * typo * deployment scripts * add more impl * fix tests
* safety redundancy * llint * Update RPLVault.sol * typo * deployment scripts * add more impl * fix tests * bug fixes * fix bugs * security+lint Update WETHVault.sol * fix tests more test test prep
* update * fix test * fix test * add test * broke test * enablePreSignedExitMessage * bug fix, fix test
* update * fix test * fix test * add test * broke test * enablePreSignedExitMessage * bug fix, fix test * test stake/unstake * add tests * beep boop bop * gas report * bad logic * bug fix tree gen * bug fixes in tree gen * submission registering * debug * debug * retire debug * skip
* recompilation, spiking, breaking, etc.. * Update gas-report.txt * hacking away... * simplify tick * further generalize deployment logic * oops * bug fixes * bug fix * support multi leb types debugging.... * suboperators can create minipools * major fixes staking ops * fix subnode op staking bug * bug fix update * big update * add tests * update * clean up / patch * Update Whitelist.sol * mega update * rn update fix buggy key-value suite * comments comments * pub sandbox * Update hardhat.config.ts
* update * update * address comment * Update RPLVault.sol
* docs Update SuperNodeAccount.sol * fix rate integration * 2nd iteration admin oracle fix test * update
* update * Update sandbox.ts
* update update * update * comments Update XRETHAdminOracle.sol
…to feature/wagmi-and-minipool-script
* Adds wagmi codegen to repository * Relocate exported typescript abis * Implements minipool launcher * Implements proper bls signatures for minipool creation * remove unused import * Additional logging on operator setup * Adds a reset task * log out the minipool public key * Adds admin send eth task for testing
…to feature/wagmi-and-minipool-script
teddy-nodeset
suggested changes
Jul 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't merge until tests get fixed. something broke the unit test pipe for contract Q/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed a few things when resolving merge conflicts. This fixes them and get's the sandbox script w/ minipool launching working again.