Implement missing status checks #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jclapis
reviewed
Jun 18, 2024
| func GetNodesetStatus(pubKey beacon.ValidatorPubkey, registeredPubkeysStatusMapping map[beacon.ValidatorPubkey]string) swtypes.NodesetStatus { | ||
| for registeredPubKey, nodesetStatus := range registeredPubkeysStatusMapping { | ||
| if registeredPubKey == pubKey { | ||
| if nodesetStatus == "REGISTERED" { |
There was a problem hiding this comment.
Making a note that we'll have to revisit this later to turn these into enum values once they've been solidified
jclapis
requested changes
Jun 18, 2024
go.mod
Outdated
| @@ -11,7 +11,7 @@ require ( | |||
| github.com/google/uuid v1.6.0 | |||
| github.com/gorilla/mux v1.8.1 | |||
| github.com/nodeset-org/hyperdrive-daemon v0.5.0-b1.0.20240614184837-e4f7a44efd10 | |||
| github.com/nodeset-org/nodeset-svc-mock v0.1.1-0.20240614184020-4f7aeb08967e | |||
| github.com/nodeset-org/nodeset-svc-mock v0.1.1-0.20240617160247-3ac8bfac0cb9 | |||
There was a problem hiding this comment.
We can update this to v0.2.0 now.
internal/tests/api/status_test.go
Outdated
| // Mark the validator as active | ||
| err = nsMock.MarkValidatorRegistered(vault, network, depositDataSet) | ||
| require.NoError(t, err) | ||
| t.Log("Deposit data set marked as uploaded") |
There was a problem hiding this comment.
This should say registered instead of uploaded.
…om:nodeset-org/hyperdrive-stakewise into feature/implement-additional-status-checks
jclapis
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.