Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace request with postman-request #231

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

orgads
Copy link
Contributor

@orgads orgads commented Jul 14, 2023

Use a maintained package until it is replaced.

@orgads
Copy link
Contributor Author

orgads commented Jul 14, 2023

@aviadhahami This replaces #195

@aviadhahami
Copy link
Collaborator

Tests pass, codecov dies; fixing

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #231 (a38561e) into master (4c7b0c2) will not change coverage.
The diff coverage is 100.00%.

❗ Current head a38561e differs from pull request most recent head 14cd6df. Consider uploading reports for the commit 14cd6df to get more accurate results

@@            Coverage Diff            @@
##            master      #231   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          141       145    +4     
=========================================
+ Hits           141       145    +4     
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aviadhahami
Copy link
Collaborator

@orgads - thanks for the patch!
any other changes or I can go ahead and merge?

@orgads
Copy link
Contributor Author

orgads commented Jul 19, 2023

I prefer rebase instead of merge, but other than that I consider it ready to merge.

Use a maintained package until it is replaced.
@aviadhahami
Copy link
Collaborator

Rebasing then :)
thx!

@aviadhahami aviadhahami merged commit 877f591 into nodevault:master Jul 20, 2023
6 checks passed
@orgads orgads deleted the postman-request branch July 20, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants