Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid HTML comments, simplify replacement logic #409

Merged
merged 11 commits into from
Mar 22, 2024
Merged

Conversation

nolanlawson
Copy link
Owner

Experimental version of the framework where we use text nodes instead of HTML comments. Also attempting to simplify the implementation a bit.

Copy link

github-actions bot commented Mar 16, 2024

📊 Tachometer Benchmark Results

Summary

benchmark-total

  • emoji-picker-element-change-tab: unsure 🔍 -3% - +1% (-0.88ms - +0.20ms)
    this-change vs tip-of-tree
  • emoji-picker-element-database-interactions: unsure 🔍 -4% - +7% (-3.89ms - +6.80ms)
    this-change vs tip-of-tree
  • emoji-picker-element-first-load: unsure 🔍 -4% - +3% (-1.84ms - +1.74ms)
    this-change vs tip-of-tree
  • emoji-picker-element-second-load: unsure 🔍 -8% - +3% (-3.08ms - +1.09ms)
    this-change vs tip-of-tree

Results

emoji-picker-element-change-tab
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
33.31ms - 33.52ms-unsure 🔍
-3% - +1%
-0.88ms - +0.20ms
tip-of-tree
tip-of-tree
33.23ms - 34.29msunsure 🔍
-1% - +3%
-0.20ms - +0.88ms
-
emoji-picker-element-database-interactions
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
99.56ms - 107.40ms-unsure 🔍
-4% - +7%
-3.89ms - +6.80ms
tip-of-tree
tip-of-tree
98.39ms - 105.65msunsure 🔍
-7% - +4%
-6.80ms - +3.89ms
-
emoji-picker-element-first-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
50.32ms - 52.81ms-unsure 🔍
-4% - +3%
-1.84ms - +1.74ms
tip-of-tree
tip-of-tree
50.32ms - 52.90msunsure 🔍
-3% - +4%
-1.74ms - +1.84ms
-
emoji-picker-element-second-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
34.79ms - 37.86ms-unsure 🔍
-8% - +3%
-3.08ms - +1.09ms
tip-of-tree
tip-of-tree
35.91ms - 38.72msunsure 🔍
-3% - +9%
-1.09ms - +3.08ms
-

tachometer-reporter-action v2 for Benchmarks

Copy link

github-actions bot commented Mar 16, 2024

Size Change: -226 B (-1%)

Total Size: 36.4 kB

Filename Size Change
./bundle.js 36.4 kB -226 B (-1%)

compressed-size-action

@nolanlawson nolanlawson changed the title fix: avoid HTML comments fix: avoid HTML comments, simplify replacement logic Mar 17, 2024
@nolanlawson nolanlawson merged commit ce950ff into master Mar 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant