Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use noto for custom font demo #432

Merged
merged 1 commit into from
Aug 4, 2024
Merged

Conversation

nolanlawson
Copy link
Owner

Twemoji seems quasi-abandoned and twemoji-colr has not had an update since Emoji v14. It doesn't make much sense to use Twemoji in our demos anymore.

Google Noto Colr Emoji seems to have a generous license and supports emoji v15.1. It also doesn't seem to suffer from the WebKit bug (although they never closed it, so I'm not totally sure...).

Copy link

github-actions bot commented Aug 4, 2024

📊 Tachometer Benchmark Results

Summary

benchmark-total

  • emoji-picker-element-change-tab: unsure 🔍 -3% - +1% (-0.91ms - +0.35ms)
    this-change vs tip-of-tree
  • emoji-picker-element-database-interactions: unsure 🔍 -4% - +4% (-4.28ms - +4.28ms)
    this-change vs tip-of-tree
  • emoji-picker-element-first-load: unsure 🔍 -6% - +3% (-2.80ms - +1.50ms)
    this-change vs tip-of-tree
  • emoji-picker-element-second-load: slower ❌ 1% - 9% (0.26ms - 3.08ms)
    this-change vs tip-of-tree

Results

emoji-picker-element-change-tab
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
33.35ms - 33.85ms-unsure 🔍
-3% - +1%
-0.91ms - +0.35ms
tip-of-tree
tip-of-tree
33.30ms - 34.46msunsure 🔍
-1% - +3%
-0.35ms - +0.91ms
-
emoji-picker-element-database-interactions
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
94.27ms - 99.90ms-unsure 🔍
-4% - +4%
-4.28ms - +4.28ms
tip-of-tree
tip-of-tree
93.86ms - 100.31msunsure 🔍
-4% - +4%
-4.28ms - +4.28ms
-
emoji-picker-element-first-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
43.50ms - 46.80ms-unsure 🔍
-6% - +3%
-2.80ms - +1.50ms
tip-of-tree
tip-of-tree
44.42ms - 47.18msunsure 🔍
-3% - +6%
-1.50ms - +2.80ms
-
emoji-picker-element-second-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
34.40ms - 36.20ms-slower ❌
1% - 9%
0.26ms - 3.08ms
tip-of-tree
tip-of-tree
32.55ms - 34.71msfaster ✔
1% - 9%
0.26ms - 3.08ms
-

tachometer-reporter-action v2 for Benchmarks

Copy link

github-actions bot commented Aug 4, 2024

Size Change: 0 B

Total Size: 36.5 kB

ℹ️ View Unchanged
Filename Size
./bundle.js 36.5 kB

compressed-size-action

@nolanlawson nolanlawson merged commit b0c189d into master Aug 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant