Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleaner deeptable instantiation pattern #172

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bmschmidt
Copy link
Collaborator

@bmschmidt bmschmidt commented Nov 11, 2024

Testing scaling to 10 billion points.


Important

Introduces fromQuadfeather method for Deeptable instantiation and renames tileManifest to loadTileManifest for improved initialization and manifest loading.

  • Deeptable Initialization:
    • Added static method fromQuadfeather in Deeptable.ts for initializing Deeptable with a quadtree from the quadfeather package.
    • Replaces direct instantiation with fromQuadfeather in Scatterplot.ts.
  • Manifest Loading:
    • Renamed tileManifest to loadTileManifest in Deeptable.ts for clarity and functionality.
  • Misc:
    • Updated load_deeptable in scatterplot.ts to use await with fromQuadfeather for asynchronous handling.

This description was created by Ellipsis for 37721e5. It will automatically update as commits are pushed.

@bmschmidt bmschmidt mentioned this pull request Nov 11, 2024
Comment on lines +183 to +184
*/
protected _makePromise(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tileManifest parameter should be more strictly typed. Instead of Partial<DS.TileManifest>, consider creating a specific interface for the minimum required properties or use a more precise type union.

Spotted by Graphite Reviewer (based on CI logs)

Is this helpful? React 👍 or 👎 to let us know.

Comment on lines +376 to +380
this._root = await Deeptable.fromQuadfeather({
baseUrl: source_url,
plot: this,
tileProxy,
});
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While await has been added, consider adding try/catch block around the Deeptable.fromQuadfeather call to properly handle potential errors during async operation.

Spotted by Graphite Reviewer (based on CI logs)

Is this helpful? React 👍 or 👎 to let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant