-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleaner deeptable instantiation pattern #172
base: main
Are you sure you want to change the base?
Conversation
*/ | ||
protected _makePromise( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tileManifest parameter should be more strictly typed. Instead of Partial<DS.TileManifest>, consider creating a specific interface for the minimum required properties or use a more precise type union.
Spotted by Graphite Reviewer (based on CI logs)
Is this helpful? React 👍 or 👎 to let us know.
this._root = await Deeptable.fromQuadfeather({ | ||
baseUrl: source_url, | ||
plot: this, | ||
tileProxy, | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While await has been added, consider adding try/catch block around the Deeptable.fromQuadfeather call to properly handle potential errors during async operation.
Spotted by Graphite Reviewer (based on CI logs)
Is this helpful? React 👍 or 👎 to let us know.
Testing scaling to 10 billion points.
Important
Introduces
fromQuadfeather
method forDeeptable
instantiation and renamestileManifest
toloadTileManifest
for improved initialization and manifest loading.fromQuadfeather
inDeeptable.ts
for initializingDeeptable
with a quadtree from the quadfeather package.fromQuadfeather
inScatterplot.ts
.tileManifest
toloadTileManifest
inDeeptable.ts
for clarity and functionality.load_deeptable
inscatterplot.ts
to useawait
withfromQuadfeather
for asynchronous handling.This description was created by for 37721e5. It will automatically update as commits are pushed.