Misc fixes for undefined behavior, crashes, and build failure #3465
+80
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`info` is local to scanQueue, so we have to store a copy in the DocumentReader to extend its lifetime. Not sure how this even worked before. Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
Attempting to notify the objects of this change from a different thread causes an error in debug builds: ``` ASSERT failure in QCoreApplication::sendEvent: "Cannot send events to objects owned by a a different thread. Current thread 0x0x1a9dc360490. Receiver '' (of type 'ChatModel') was created in thread 0x0x1a9ad1a99f0", file C:\Users\qt\work\qtbase\src\corelib\kernel\qcoreapplication.cpp, line 557 ``` QObject::setParent is not documented to be thread-safe. Signed-off-by: Jared Van Bortel <[email protected]>
This entry causes the Visual Studio build to fail. Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
This fixes the following assertion failure in Qt debug builds: ``` ASSERT: "bytes <= bufferSize" in file C:\Users\qt\work\qt\qtbase\src\corelib\tools\qringbuffer.cpp, line 75 ``` The message handler is called from the thread that sends the message, so we need to make sure only one thread can access the file at a time, since QFile is not inherently threadsafe. Signed-off-by: Jared Van Bortel <[email protected]>
manyoso
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The theme of this PR is things I noticed while trying to make Windows ARM more stable. None of them seem to affect the official releases in practice.