Couple of additional tests for clarity #5
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of looking at typelevel/simulacrum#49 I wanted to find out a bit more about the
imp
macro.In particular, I wanted to prove to myself that using
macro summon
forapply
was better than usingimp[A]
for theapply
implementation.I was close to 100% confident on that anyway, but I wrote a couple of tests to make sure.
As part of doing that, I found the tests that had already been written very instructive, in the way that they tell a story by creating a baseline for comparison in a couple of the tests and then using that as a base to draw conclusions in the other tests.
I updated the descriptions of the tests to tell this story using the test descriptions in a more english language way, and also included the two extra tests I'd added for myself.
I thought this would be worth submitting as I certainly found the whole thing instructive and educational and I am hoping that these changes may also make the tests useful for others.