Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couple of additional tests for clarity #5

Merged
merged 1 commit into from
Apr 5, 2016
Merged

Conversation

mikejcurry
Copy link
Contributor

As part of looking at typelevel/simulacrum#49 I wanted to find out a bit more about the imp macro.

In particular, I wanted to prove to myself that using macro summon for apply was better than using imp[A] for the apply implementation.

I was close to 100% confident on that anyway, but I wrote a couple of tests to make sure.

As part of doing that, I found the tests that had already been written very instructive, in the way that they tell a story by creating a baseline for comparison in a couple of the tests and then using that as a base to draw conclusions in the other tests.

I updated the descriptions of the tests to tell this story using the test descriptions in a more english language way, and also included the two extra tests I'd added for myself.

I thought this would be worth submitting as I certainly found the whole thing instructive and educational and I am hoping that these changes may also make the tests useful for others.

@non
Copy link
Owner

non commented Apr 5, 2016

Hi @mikejcurry sorry I missed this! Thanks, these are great!

@non non merged commit 18ac04f into non:master Apr 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants