Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses some of #490 Plan output improvement #550

Merged
merged 3 commits into from
Aug 7, 2023
Merged

Conversation

smoy
Copy link
Contributor

@smoy smoy commented Aug 7, 2023

What changed?

  • Only output the Exception section if there are exceptions
  • Aggregate Create, Update, Delete, Detach, Attach actions instead of outputting just n distinct actions

Rationale

How was it tested?

If it was manually verified, list the instructions for your reviewers to follow.

  • Unit Tests
  • Functional Tests
  • Manually Verified

See https://github.com/noqdev/iambic-templates-itest/pull/322

@smoy smoy self-assigned this Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02% 🎉

Comparison is base (3658c52) 83.74% compared to head (d51be9a) 83.77%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #550      +/-   ##
==========================================
+ Coverage   83.74%   83.77%   +0.02%     
==========================================
  Files         105      105              
  Lines       12232    12248      +16     
==========================================
+ Hits        10244    10261      +17     
+ Misses       1988     1987       -1     
Flag Coverage Δ
functional_tests 65.95% <100.00%> (+0.12%) ⬆️
functional_tests_config_discovery 46.02% <0.00%> (-0.07%) ⬇️
unit_tests 74.05% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
iambic/output/models.py 96.06% <100.00%> (+0.38%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@castrapel castrapel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smoy smoy merged commit d243eb9 into main Aug 7, 2023
@smoy smoy deleted the fix/plan-improvement branch August 7, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants