-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meetings bot setup: Remove the SQL injection, use admin API #758
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Christian Paul <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to check if this is referenced somewhere and needs replacing
for example
https://github.com/nordeck/matrix-meetings/blob/main/charts/matrix-meetings-bot/templates/configmap.yaml#L7
Signed-off-by: Christian Paul <[email protected]>
Signed-off-by: Christian Paul <[email protected]>
@@ -55,44 +55,27 @@ spec: | |||
{{- end }} | |||
{{- if .Values.init.disableRateLimitInDB.enabled }} | |||
- name: setratelimit | |||
image: {{ .Values.init.postgresClient.image }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we don't really need psql anymore, let's get rid of it entirely
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as discussed we should:
- sort the getFreshDeviceToken step before the disableRateLimitInDB
- regardless, make the disableRateLimitInDB "atomic" by adding login and logout step to get a token
Signed-off-by: Christian Paul <[email protected]>
We overlooked that the bot does not use an admin account, so this solution is not that simple after all |
I'll need help to
.Values.init.nodejs.image
if we don't want a specific NodeJS image from DockerHub hard-coded