Remove ruff #594
Merged
Remove ruff #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Choice of linter toolchain is a matter for project developers. `ruff` was pushed by an external contributor, and was accepted to hopefully improve interest/engagement in maintenance. However, there was no particular reason to use `ruff` and it puts us in the position of opting out of a lot of configs rather than opting in to what we want. flake8 also offers a plugin framework which allows for checks like `flake8-typing-as-t` to be easily added post-hoc. In addition to flake8, reapply isort and pyupgrade, and add slyp.
pre-commit autoupdate + upadup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply put, I tried out
ruffbecause someone came along and pushed me to do it, and I was open to the idea.But frankly if you aren't a maintainer of a project you really ought not to be trying to make decisions about the development toolchain.
All of my other projects are using the same toolchain and I'm just making
nose2match them so that it's easier to swap in and do work when necessary.