Add multi_invoice_lookup to NWC / NIP47 #1385
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@blackcoffeexbt have you implemented this somewhere? I'm interested to hear what are you working on! |
Not yet but I will. We're adding NWC support to LNbits. With LNbits there's likely to be multiple payments that aren't settled so having multi invoice lookup support would be really useful. I imagine other projects would benefit from it too. |
|
Would notifications possibly solve this? #1164 |
|
@rolznz Almost certainly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performing individual lookups for multiple invoices can be very network heavy and potentially a DOS vector. Adding a
multi_invoice_lookupmethod to NIP47 will reduce network usage and reduce the potential for a wallet service / relay DOS attack.