Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SVR-320] 기존 Villages 데이터를 Subscription으로 변경 #146

Merged
merged 2 commits into from
Mar 25, 2024
Merged

[SVR-320] 기존 Villages 데이터를 Subscription으로 변경 #146

merged 2 commits into from
Mar 25, 2024

Conversation

upa-r-upa
Copy link
Member

@upa-r-upa upa-r-upa commented Mar 25, 2024 •
edited
Loading

TL;DR

  • 기존에 Query로 제공하던 villages 데이터를 subscription으로 변경했습니다.
  • 그리고 던전 데이터에 던전에서 보상으로 제공될 Seed id도 리턴하도록 추가했습니다.

배경 및 목표

  • 기존엔 Village는 CSV를 읽어서 단순히 전달만 하는 개념이어서 Query로 제공했었는데,
  • 이제는 마을 아래에 던전 요소를 리턴하게 되면서 실시간으로 수정되어야 할 이유가 생겨서 바뀌었습니다.

작업 사항

image

@upa-r-upa upa-r-upa requested a review from a team as a code owner March 25, 2024 11:12
@upa-r-upa upa-r-upa requested review from Atralupus and kth1888 and removed request for a team March 25, 2024 11:12
@notion-workspace Notion Workspace
Copy link

[던전] 기존 Villages 데이터를 Subscription으로 변경

@upa-r-upa upa-r-upa self-assigned this Mar 25, 2024
@upa-r-upa upa-r-upa added enhancement New feature or request backend labels Mar 25, 2024
Atralupus
Atralupus approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@Atralupus Atralupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM MTGL LGTM MTGL LGTM MTGL LGTM MTGL LGTM MTGL LGTM MTGL LGTM MTGL LGTM MTGL LGTM MTGL LGTM MTGL

@upa-r-upa upa-r-upa merged commit ab5f0da into feat/dungeon-detail-read Mar 25, 2024
1 check passed
@upa-r-upa upa-r-upa deleted the feat/village-to-subscription branch March 25, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Atralupus Atralupus Atralupus approved these changes

@kth1888 kth1888 Awaiting requested review from kth1888 kth1888 was automatically assigned from not-blond-beard/dev

Assignees

@upa-r-upa upa-r-upa

Labels
backend enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@upa-r-upa @Atralupus