Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SVR-328] ShowMeTheMoneyAction 추가 #152

Merged
merged 2 commits into from
Apr 6, 2024

Conversation

Atralupus
Copy link
Member

TL;DR

개발 편의를 위해 치트 액션을 추가합니다. 서명도 필요 없으며 쿼리 요청을 하면 해당 주소에 아이템과 음식을 넣어줍니다.

배경 및 목표

작업 사항

리뷰어가 중점적으로 볼 사항

@Atralupus Atralupus self-assigned this Apr 4, 2024
@Atralupus Atralupus requested a review from a team as a code owner April 4, 2024 16:31
@Atralupus Atralupus requested review from upa-r-upa and kth1888 and removed request for a team April 4, 2024 16:31
Copy link

@Atralupus Atralupus enabled auto-merge April 4, 2024 16:31
@Atralupus Atralupus disabled auto-merge April 6, 2024 16:47
@Atralupus Atralupus merged commit 8a8c273 into not-blond-beard:main Apr 6, 2024
Comment on lines +33 to +34
PrivateKey privateKey = PrivateKey.FromString("eda6ef63ae945cd15572fcf7d6635a8b3f8d86e85b57a353b482bc82c7fd2ad4");

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

어차피 테스트용 Action이니 Private key를 완전히 입력받게 했어도 괜찮았을 것 같아요
여러 유저를 테스트 해봐야 할 상황이 프론트에서 많을것 같다는..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

액션 안에서는 슈퍼권한이라 괜찮을 듯 합니다

@upa-r-upa
Copy link
Member

꼭 필요한 액션이었는데 작업 잘 해주셨군요 굿굿

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants