Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SVR-298] 던전점령권 판매 기능 추가 #160

Merged
merged 4 commits into from
Apr 16, 2024
Merged

[SVR-298] 던전점령권 판매 기능 추가 #160

merged 4 commits into from
Apr 16, 2024

Conversation

Atralupus
Copy link
Member

TL;DR

SSIA

배경 및 목표

작업 사항

리뷰어가 중점적으로 볼 사항

@Atralupus Atralupus requested a review from a team as a code owner April 14, 2024 14:28
@Atralupus Atralupus requested review from upa-r-upa and kth1888 and removed request for a team April 14, 2024 14:28
@notion-workspace Notion Workspace
Copy link

[던전] 특정 던전의 점령권 반환 기능 (시스템에 반환)

upa-r-upa
upa-r-upa requested changes Apr 14, 2024
View reviewed changes
Copy link
Member

@upa-r-upa upa-r-upa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

작업이 전체적으로 현재 State랑 안맞게 작업된 것 같아요
점령권을 시스템에 판매 한거니까 현재 점령중인 사람을 기록하는 GlobalDungeonState에서 지워야 하는건데
엉뚱한 history가 삭제되고 있네요

@upa-r-upa
Copy link
Member

@Atralupus 잊고 계신 것 같아 리마인드 해드립니다..

@Atralupus Atralupus self-assigned this Apr 16, 2024
@Atralupus
Copy link
Member Author

작업이 전체적으로 현재 State랑 안맞게 작업된 것 같아요 점령권을 시스템에 판매 한거니까 현재 점령중인 사람을 기록하는 GlobalDungeonState에서 지워야 하는건데 엉뚱한 history가 삭제되고 있네요

수정해봤습니다

upa-r-upa
upa-r-upa approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@upa-r-upa upa-r-upa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

너무 고생하셨습니다~

@Atralupus Atralupus added this pull request to the merge queue Apr 16, 2024
Merged via the queue into not-blond-beard:main with commit 4ab95ca Apr 16, 2024
1 check passed
@Atralupus Atralupus deleted the feat/sell-dongeon-conquest branch April 16, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upa-r-upa upa-r-upa upa-r-upa approved these changes

@kth1888 kth1888 Awaiting requested review from kth1888 kth1888 is a code owner automatically assigned from not-blond-beard/dev

Assignees

@Atralupus Atralupus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Atralupus @upa-r-upa