[SVR-14] 재료 조회 기능 추가 #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kth1888
requested review from
Atralupus and
upa-r-upa
and removed request for
a team
Atralupus
approved these changes
Aug 12, 2023
|
|
||
| public class ReadIngredient : MonoBehaviour | ||
| { | ||
| public string pkHex = "eda6ef63ae945cd15572fcf7d6635a8b3f8d86e85b57a353b482bc82c7fd2ad4"; |
There was a problem hiding this comment.
pk를 static class로 선언해두고 사용하심 중복 제거에 도움 될겁니다
|
|
||
| GraphApi.Query readIngredient = SavorReference.GetQueryByName("ReadAllIngredient", GraphApi.Query.Type.Subscription); | ||
|
|
||
| readIngredient.SetArgs(new { address = "0x53103C2D7875D2f5f02AeC3075155e268a6e3A94" }); |
There was a problem hiding this comment.
이 address도 동일하게 static으로 선언해두시는게 편할겁니다
더해서 나중에 다른 address로 조회할 수 있도록 변경될 가능성이 상당히 높으니 입력 받도록 미리 해두시는것도...
There was a problem hiding this comment.
다음 작업때 반영할 수 있도록 해보겠습니다 !!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
기존 씬 + 코드 재사용하여 Ingredient 조회 후 파싱 + 스크린에 출력
Subscription을 계속 유지시키므로 HashSet 이용하여 스크린 텍스트가 중복으로 더해져 출력하는 것을 방지