-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SVR-113] 인벤토리 UI 재구성 #58
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kth1888
commented
Aug 17, 2023
프리팹 생성, 값 다 제대로 들어갔으나 텍스트가 보이지 않습니다.
-텍스트 보이지 않는 이슈 해결 완료- |
kth1888
requested review from
Atralupus and
upa-r-upa
and removed request for
a team
August 19, 2023 17:52
upa-r-upa
force-pushed
the
feat/inventory
branch
from
August 19, 2023 18:36
4c7f94b
to
a42fd2f
Compare
upa-r-upa
approved these changes
Aug 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다.
그런데 이 작업은 UI 재구성이라 기존 인벤토리 작업에 있던 내용들은
음식 생성, 레시피 UI를 제외하곤 전부 이관됐어야 하는게 의도인데요.
지금 보니까 식재료 생성 API는 연결이 안되어 있는 것 같아요.
식재료 생성 API 마이그레이션은 노션에 티켓 하나 추가해드릴테니 레시피 관련 작업 끝나고 나면 하시면 될 것 같아요.
추가로 레시피쪽 작업 파일 하나가 섞여 들어오긴 했는데.. 다음부턴 처음부터 제대로 분기를 나누시면 좋겠네요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.