Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SVR-113] 인벤토리 UI 재구성 #58

Merged
merged 5 commits into from
Aug 21, 2023
Merged

[SVR-113] 인벤토리 UI 재구성 #58

merged 5 commits into from
Aug 21, 2023

Conversation

kth1888
Copy link
Member

@kth1888 kth1888 commented Aug 17, 2023

image 프리팹 생성, 값 다 제대로 들어갔으나 텍스트가 보이지 않습니다.

@notion-workspace
Copy link

인벤토리 UI 생성

@upa-r-upa
Copy link
Member

-텍스트 보이지 않는 이슈 해결 완료-

@kth1888
Copy link
Member Author

kth1888 commented Aug 19, 2023

image

@kth1888 kth1888 changed the title [SVR-113] 인벤토리 UI 생성 [SVR-113] 인벤토리 UI 재구성 Aug 19, 2023
@kth1888
Copy link
Member Author

kth1888 commented Aug 19, 2023

image
인벤토리 리스트 창 크기를 키워서 해결했습니다.

@kth1888 kth1888 marked this pull request as ready for review August 19, 2023 17:52
@kth1888 kth1888 requested a review from a team as a code owner August 19, 2023 17:52
@kth1888 kth1888 requested review from Atralupus and upa-r-upa and removed request for a team August 19, 2023 17:52
Copy link
Member

@upa-r-upa upa-r-upa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다.

그런데 이 작업은 UI 재구성이라 기존 인벤토리 작업에 있던 내용들은
음식 생성, 레시피 UI를 제외하곤 전부 이관됐어야 하는게 의도인데요.

지금 보니까 식재료 생성 API는 연결이 안되어 있는 것 같아요.
식재료 생성 API 마이그레이션은 노션에 티켓 하나 추가해드릴테니 레시피 관련 작업 끝나고 나면 하시면 될 것 같아요.

추가로 레시피쪽 작업 파일 하나가 섞여 들어오긴 했는데.. 다음부턴 처음부터 제대로 분기를 나누시면 좋겠네요.

@upa-r-upa upa-r-upa marked this pull request as draft August 21, 2023 10:25
@upa-r-upa upa-r-upa marked this pull request as ready for review August 21, 2023 10:25
@kth1888 kth1888 merged commit 328c565 into main Aug 21, 2023
1 check passed
@kth1888 kth1888 deleted the feat/inventory branch August 21, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants