Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux/x11: Support window icons #492

Merged
merged 1 commit into from
Oct 19, 2024
Merged

linux/x11: Support window icons #492

merged 1 commit into from
Oct 19, 2024

Conversation

not-fl3
Copy link
Owner

@not-fl3 not-fl3 commented Oct 19, 2024

No description provided.

@not-fl3 not-fl3 merged commit 1c5729b into master Oct 19, 2024
20 checks passed
@Garfield-hr
Copy link

Garfield-hr commented Dec 6, 2024

Hi,

Thank you for developing this remarkable render engine.

I'm currently developing a simulation software based on miniquad on Linux. I noticed that window icon support for Linux/X11 was added in this PR, and I'm trying to implement an icon for my application.

However, despite the merged changes, I'm still unable to see any window icon on my Linux/X11 system. I've tested this with the triangle example, and the window still does not show icon (please see the attached screenshot).
image

Based on my debugging:

  1. I've verified that the update_window_icon function is being called with the proper icon data (confirmed via debug prints)
  2. The same code works correctly on Windows, where the custom icon is displayed properly
  3. On my Linux/X11 system, no window icon appears

Could you help confirm if there are any additional X11-specific steps needed to properly implement the window icon functionality?

Thank you for your time.

@not-fl3
Copy link
Owner Author

not-fl3 commented Dec 6, 2024

Unfortunately it works just fine on my machine :(

I would recommend to open this as an issue, not a PR comment, this way it will not be lost in time.

@Garfield-hr
Copy link

I opened an issue in #501

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants