Skip to content
This repository has been archived by the owner on Feb 11, 2022. It is now read-only.

add kotlin example to readme #270

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add kotlin example to readme #270

wants to merge 2 commits into from

Conversation

blundell
Copy link

Problem

No kotlin example in the readme

Solution

Add kotlin example

Test(s) added

only my eyes

Paired with

Nobody

@blundell
Copy link
Author

CI build failed cos

Errors found:

/storage/jenkins/workspace/no-player-prb/core/build.gradle:62: Error: A newer version of com.google.android.exoplayer:exoplayer than 2.9.6 is available: 2.10.1 [GradleDependency]
    implementation 'com.google.android.exoplayer:exoplayer:2.9.6'
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/storage/jenkins/workspace/no-player-prb/core/build.gradle:67: Error: A newer version of org.mockito:mockito-core than 2.27.0 is available: 2.28.2 [GradleDependency]
    testImplementation 'org.mockito:mockito-core:2.27.0'
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

not really a part of this PR

@Mecharyry
Copy link
Contributor

I agree. It's because we haven't updated master in a long time. We need to remove MediaPlayer from the code and do some tidying up after we added the AdsLoader.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants