fix(arborist): inherit overrides from fsParent #8108
+240
−677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrevorBurnham
changed the title
TrevorBurnham
changed the title
TrevorBurnham
changed the title
TrevorBurnham
force-pushed
the
fix-workspace-overrides
branch
from
1f64523 to
e83ca91
Compare
2 tasks
TrevorBurnham
force-pushed
the
fix-workspace-overrides
branch
2 times, most recently
from
6d5d51e to
e70cfb8
Compare
19 tasks
Closed
1 task
|
CI failures are hopefully fixed in #8115 This PR has been added to npm/statusboard#920, and @owlstronaut will make sure it's not colliding w/ existing work there. |
Fixes npm#4205 In the virtual tree, workspace nodes are `fsChildren` of the root, not `children`. As a result, they weren't inheriting the root's overrides, causing those overrides to be ignored for all dependencies of workspaces. The fix here is to inherit `fsParent.overrides` whenever possible.
TrevorBurnham
force-pushed
the
fix-workspace-overrides
branch
from
e70cfb8 to
7e510a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to reviewers: The CI failures are unrelated to the code changes in this CR. They're caused by
git dirtycomplaining because there was a release of@npmcli/gitthat hasn't been merged in yet: npm/git#224Currently, a package's
overrideshave no effect on dependencies declared in its workspaces (#4205).I did some digging and found that:
fsChildrenof the root, notchildren.parent, but not from theirfsParent.As a result, workspace nodes in the virtual tree weren't inheriting the root's overrides.
The fix here is to allow nodes to inherit
fsParent.overrides. I've added tests forload-virtualandreifyto demonstrate that overrides are correctly applied to a workspace dependency with this change.References
Fixes #4205