Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update "process_frame" function to process 2DS data correctly #5

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

huangynj
Copy link

@huangynj huangynj commented Aug 6, 2024

Hi @kennybala97,

I have updated the "process_frame" function to process 2DS data correctly based on the method I proposed in
#4 (comment)

I tested it using 1-min data and it works fine.

Yongjie

@kennybala97
Copy link
Collaborator

@huangynj thank you for submitting this fix! It's a busy week this week for us at NRC but I'll go through the code changes and get back to you hopefully sometime next week. Thanks again!

@kennybala97
Copy link
Collaborator

kennybala97 commented Aug 6, 2024

Actually, one request for you @huangynj if you have the time. Would you be able to create a new branch on your end, rebased from main, add the changes to there instead? This way I can clone the branch and play around with it. As it currently is, I have to first merge the changes with main before I can actually run the code. I can also do this on my end but it will be messier as I will have to copy portions of the code manually. I can create the branch first and you can push there also, if it make life easier.

@huangynj
Copy link
Author

huangynj commented Aug 6, 2024

Hi @kennybala97, I have created a new branch: https://github.com/huangynj/NRC-SPIFpy/tree/2DS_HVPS_fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants