boot/zephyr/nrf_cleanup: cleanup uarte pins #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvlsianpu
force-pushed
the
bugfix/NCSIDB_1194
branch
from
df7b400 to
546fcfc
Compare
nvlsianpu
force-pushed
the
bugfix/NCSIDB_1194
branch
from
546fcfc to
7310e4f
Compare
vidarbe
approved these changes
Mar 6, 2024
nvlsianpu
force-pushed
the
bugfix/NCSIDB_1194
branch
from
13284bc to
87b6c49
Compare
de-nordic
approved these changes
Mar 7, 2024
sigvartmh
approved these changes
Mar 8, 2024
nvlsianpu
force-pushed
the
bugfix/NCSIDB_1194
branch
2 times, most recently
from
3b465f9 to
f687068
Compare
|
@nvlsianpu Can you rebase this, please? |
|
moving it out of NCS 2.7.0 @nvlsianpu FYI |
Added procedure which does configure UARTE pins to the default states. This allows to reduce power consumption if pin is floating. clean-up UARTE only if its driver was enabled Signed-off-by: Andrzej Puzdrowski <[email protected]>
nvlsianpu
force-pushed
the
bugfix/NCSIDB_1194
branch
from
f687068 to
54eb381
Compare
nordicjm
reviewed
Mar 3, 2025
Comment on lines
94
to
+101
| nrfy_uarte_disable(current); | ||
|
|
||
| uint32_t pin[4]; | ||
|
|
||
| pin[0] = nrf_uarte_tx_pin_get(current); | ||
| pin[1] = nrf_uarte_rx_pin_get(current); | ||
| pin[2] = nrf_uarte_rts_pin_get(current); | ||
| pin[3] = nrf_uarte_cts_pin_get(current); |
There was a problem hiding this comment.
this mixes nrfy_uarte and nrf_uarte, should probably stick to nrfy_uarte and use nrfy_uarte_pins_get or just use nrfy_uarte_pins_disconnect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added procedure which does configure UARTE pins to the default states. This allows to reduce power consumption if pin is floating.
Ref.: NCSIDB-1194