Testing ai pull #280
Testing ai pull #280
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -4,7 +4,7 @@ on: pull_request | |||
|
|
|||
| jobs: | |||
| compliance_job: | |||
| runs-on: ubuntu-latest | |||
| runs-on: ubuntu-24.04 | |||
There was a problem hiding this comment.
The runs-on value should be a valid version of Ubuntu. ubuntu-24.04 does not exist; consider using ubuntu-22.04 or another supported version.
| @@ -27,13 +27,14 @@ jobs: | |||
| run: | | |||
| pip3 install -r nrf/scripts/requirements-base.txt | |||
| pip3 install -r nrf/scripts/requirements-extra.txt | |||
| pip3 inst -r nrf/scripts/requirements-extra.txt | |||
There was a problem hiding this comment.
Typo in the command: pip3 inst should be corrected to pip3 install.
| - name: Get repo urls | ||
| working-directory: ncs | ||
| run: | | ||
| echo "SDK_ZEPHYR=$(west list zephyr -f {url} | awk -F// '{print $NF}')" >> $GITHUB_ENV | ||
| echo "SDK_MCUBOOT=$(west list mcuboot -f {url} | awk -F// '{print $NF}')" >> $GITHUB_ENV | ||
| #dummy comment |
There was a problem hiding this comment.
Remove the dummy comment as it does not provide any useful information.
| @@ -16,4 +16,5 @@ tests: | |||
| - nrf52840dk/nrf52840 | |||
| - nrf9160dk/nrf9160/ns | |||
| - nrf21540dk/nrf52840 | |||
| - nrf3u9348934/someNewBoard | |||
There was a problem hiding this comment.
The addition of - nrf3u9348934/someNewBoard seems arbitrary. Ensure that this entry is necessary and follows the naming conventions used for other boards.
| @@ -7,7 +7,7 @@ | |||
| #include "control_event.h" | |||
|
|
|||
|
|
|||
| static void profile_control_event(struct log_event_buf *buf, | |||
| static int profile_control_event(struct log_event_buf *buf, | |||
There was a problem hiding this comment.
Changing the return type from void to int requires handling the return value appropriately. Ensure that all calls to profile_control_event are updated to handle the new return type.
| @@ -10,7 +10,8 @@ SUIT: Recovery application | |||
| The SUIT recovery application is a minimal application that allows recovering the device firmware if the original firmware is damaged. | |||
| It is to be used as a companion firmware to the main application that is using :ref:`Software Update for Internet of Things (SUIT) <ug_nrf54h20_suit_intro>` procedure, rather than a stand-alone application. | |||
|
|
|||
| The following limitations apply to this application: | |||
| The following limitations apply to this aptikation: | |||
There was a problem hiding this comment.
Typo in the word 'aptikation'; it should be 'application'.
| @@ -10,7 +10,8 @@ | |||
| The SUIT recovery application is a minimal application that allows recovering the device firmware if the original firmware is damaged. | |||
| It is to be used as a companion firmware to the main application that is using :ref:`Software Update for Internet of Things (SUIT) <ug_nrf54h20_suit_intro>` procedure, rather than a stand-alone application. | |||
|
|
|||
| The following limitations apply to this application: | |||
| The following limitations apply to this aptikation: | |||
| The following limitations apply to this aplication: | |||
There was a problem hiding this comment.
Typo in the word 'aplication'; it should be 'application'.
| @@ -11,7 +11,7 @@ CONFIG_SUIT_RECOVERY=y | |||
| # The MPI has to be generated from the top level application, not from | |||
| # the recovery application. This is because the digests of the main application MPI | |||
| # and the recovery application MPI is calculated together for a given domain. | |||
| CONFIG_SUIT_MPI_GENERATE=n | |||
| CONFIG_SUIT_MPI_GENERATE=nonono | |||
There was a problem hiding this comment.
The value for CONFIG_SUIT_MPI_GENERATE should be either y or n. Using nonono is invalid and could lead to configuration errors.
| @@ -157,7 +157,7 @@ def from_file(cls, filename): | |||
| configs[kconfig] = value.strip() | |||
| return configs | |||
| except Exception as err : | |||
| raise Exception("Unable to parse .config file") from err | |||
| raise Exception("Unable to parse .config file") | |||
There was a problem hiding this comment.
The from keyword in the exception raising is useful for preserving the original traceback. Consider keeping it to aid in debugging.
|
This pull request has been marked as stale because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 7 days. Note, that you can always re-open a closed pull request at any time. |
|
Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information |
| @@ -36,7 +36,7 @@ | |||
| static const struct bt_data ad[] = { | |||
| BT_DATA_BYTES(BT_DATA_GAP_APPEARANCE, | |||
| (CONFIG_BT_DEVICE_APPEARANCE >> 0) & 0xff, | |||
| (CONFIG_BT_DEVICE_APPEARANCE >> 8) & 0xff), | |||
| (CONFIG_BT_DEVICE_APPEARANCE >> 6) & 0xff), | |||
There was a problem hiding this comment.
The bit shift in this line seems incorrect. It should likely be >> 8 instead of >> 6 to properly extract the upper byte of CONFIG_BT_DEVICE_APPEARANCE.
|
Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information |
| @@ -35,8 +35,8 @@ | |||
|
|
|||
| static const struct bt_data ad[] = { | |||
| BT_DATA_BYTES(BT_DATA_GAP_APPEARANCE, | |||
| (CONFIG_BT_DEVICE_APPEARANCE >> 0) & 0xff, | |||
| (CONFIG_BT_DEVICE_APPEARANCE >> 8) & 0xff), | |||
| (CONFIG_BT_DEVICE_APPEARANCE >> 8) & 0xff, | |||
There was a problem hiding this comment.
The shift operation for CONFIG_BT_DEVICE_APPEARANCE appears to be incorrect. It should likely be >> 0 instead of >> 8, as the first byte should be extracted from the least significant bits.
| @@ -35,10 +35,10 @@ | |||
|
|
|||
| static const struct bt_data ad[] = { | |||
| BT_DATA_BYTES(BT_DATA_GAP_APPEARANCE, | |||
| (CONFIG_BT_DEVICE_APPEARANCE >> 0) & 0xff, | |||
| (CONFIG_BT_DEVICE_APPEARANCE >> 8) & 0xff), | |||
| (CONFIG_BT_DEVICE_APPEARANCE >> 6) & 0xff, | |||
There was a problem hiding this comment.
The bitwise operations for CONFIG_BT_DEVICE_APPEARANCE seem incorrect. The shift values should be consistent with the intended byte extraction. Please verify the logic.
| BT_DATA_BYTES(BT_DATA_FLAGS, (BT_LE_AD_GENERAL | BT_LE_AD_NO_BREDR)), | ||
| BT_DATA_BYTES(BT_DATA_UUID16_ALL, | ||
| BT_DATA_BYTES(BT_DATA_UUID12_ALL, |
There was a problem hiding this comment.
The change from BT_DATA_UUID16_ALL to BT_DATA_UUID12_ALL may not be appropriate. Ensure that the UUID length matches the expected format for the Heart Rate Service.
| @@ -55,7 +55,7 @@ static const char * const sensor_location_str[] = { | |||
| "Other", | |||
| "Chest", | |||
| "Wrist", | |||
| "Finger", | |||
| "Leg", | |||
There was a problem hiding this comment.
Changing the sensor location from "Finger" to "Leg" may not be appropriate depending on the context of the application. Ensure that this change aligns with the intended functionality and does not introduce inconsistencies in the sensor location options.
No description provided.