Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zcbor 0.8.1 #13768

Merged
merged 15 commits into from
Feb 20, 2024
Merged

zcbor 0.8.1 #13768

merged 15 commits into from
Feb 20, 2024

Conversation

oyvindronningstad
Copy link
Contributor

No description provided.

@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Jan 26, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 26, 2024 •
edited
Loading

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
matter nrfconnect/sdk-connectedhomeip@c36fcaf nrfconnect/sdk-connectedhomeip@a4d48b7 (master) nrfconnect/[email protected]
mcuboot nrfconnect/sdk-mcuboot@3fe867f nrfconnect/sdk-mcuboot@55a0f64 (main) nrfconnect/[email protected]
nrfxlib nrfconnect/sdk-nrfxlib@3cfb84e nrfconnect/sdk-nrfxlib@d80b51a (main) nrfconnect/[email protected]
sidewalk nrfconnect/sdk-sidewalk@08d999c nrfconnect/sdk-sidewalk@389f338 nrfconnect/[email protected]
zephyr nrfconnect/sdk-zephyr@ea1fd93 nrfconnect/sdk-zephyr@c5c7fb3 (main) nrfconnect/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@oyvindronningstad oyvindronningstad changed the title Zcbor 0.8.1 zcbor 0.8.1 Jan 26, 2024
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 26, 2024 •
edited
Loading

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
desktop52_verification X
test-fw-nrfconnect-ble X
test-fw-nrfconnect-ble_samples X
test-fw-nrfconnect-chip X
test-fw-nrfconnect-fem X
test-fw-nrfconnect-fw-update X
test-fw-nrfconnect-nfc X
test-fw-nrfconnect-nrf-iot_cloud X
test-fw-nrfconnect-nrf-iot_mosh X
test-fw-nrfconnect-nrf-iot_positioning X
test-fw-nrfconnect-nrf-iot_samples X
test-fw-nrfconnect-nrf-iot_serial_lte_modem X
test-fw-nrfconnect-nrf-iot_thingy91 X
test-fw-nrfconnect-nrf-iot_zephyr_lwm2m X
test-fw-nrfconnect-rpc X
test-fw-nrfconnect-rs X
test-fw-nrfconnect-thread X
test-fw-nrfconnect-zigbee X
test-sdk-audio X
test-sdk-find-my X
test-sdk-sidewalk X

test-fw-nrfconnect-chip: added because there was no .github/test-spec.yml in 'matter'
test-sdk-sidewalk: added because there was no .github/test-spec.yml in 'sidewalk'

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 29, 2024 •
edited
Loading

The changes to the 'requirements-fixed.txt' have been added to this PR.
All further changes to any of the requirements file will automatically be applied as long an 👀 is present.

Note: This comment is automatically posted and updated by the Comment GitHub Action.

@oyvindronningstad oyvindronningstad force-pushed the zcbor-0.8.1 branch 3 times, most recently from 70ff64f to 11ab5d5 Compare February 2, 2024 11:18
@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label Feb 2, 2024
@oyvindronningstad oyvindronningstad force-pushed the zcbor-0.8.1 branch 2 times, most recently from c0d3bee to 25326e1 Compare February 5, 2024 12:51
@oyvindronningstad oyvindronningstad marked this pull request as ready for review February 5, 2024 12:52
@shanthanordic shanthanordic added DNM and removed DNM labels Feb 14, 2024
@jfischer-no
Copy link
Contributor

jfischer-no commented Feb 20, 2024 •
edited
Loading

@oyvindronningstad Please update revisions/rebase

@jfischer-no jfischer-no mentioned this pull request Feb 20, 2024
Closed
oyvindronningstad and others added 14 commits February 20, 2024 11:55
@oyvindronningstad @jfischer-no
west.yml: Update Zephyr to bring in zcbor 0.8.1
5c48ed3 
- Add support for unordered maps
- Performance improvements
- Naming improvements for generated code
- Bugfixes

Update MCUboot, nrfxlib, matter, and sidewalk as well

Signed-off-by: Øyvind Rønningstad <[email protected]>
@oyvindronningstad @jfischer-no
nrf_provisioning: Update cbor generation script and patches
4dcbc72 
For zcbor 0.8.1

Signed-off-by: Øyvind Rønningstad <[email protected]>
@oyvindronningstad @jfischer-no
nrf_provisioning: Regenerate cbor from cddl using script
1c65ce3 
Updating to zcbor 0.8.1

Signed-off-by: Øyvind Rønningstad <[email protected]>
@oyvindronningstad @jfischer-no
nrf_provisioning: Adapt non-generated code to zcbor 0.8.x
aa0aa22 
New generated symbol names

Signed-off-by: Øyvind Rønningstad <[email protected]>
@oyvindronningstad @jfischer-no
fmfu_fdev: Improve cbor generation and zcbor integration
19aa36f 
And regenerate using zcbor 0.8.1
Add prompt to FMFU_CDDL_DECODER_GENERATE to allow usage from the command
line.
Run clang-format when code has been copied, so that clang-format always
finds the config file.

Signed-off-by: Øyvind Rønningstad <[email protected]>
@oyvindronningstad @jfischer-no
nrf_cloud: coap: Update zcbor build script
a14dc3c 
Remove non-functional use of CDDL_CBOR_CANONICAL which is defunct
Automatically put the current year in the copyright

Signed-off-by: Øyvind Rønningstad <[email protected]>
@oyvindronningstad @jfischer-no
nrf_cloud: coap: Regenerate cbor
9faff06 
with zcbor 0.8.1

Signed-off-by: Øyvind Rønningstad <[email protected]>
@oyvindronningstad @jfischer-no
nrf_cloud: coap: Adapt non-generated code to zcbor 0.8.x
357f23e 
New generated symbol names

Signed-off-by: Øyvind Rønningstad <[email protected]>
@oyvindronningstad @jfischer-no
tests: zcbor: Adapt to zcbor 0.8.x
1ca9ac3 
Generated symbol names and zcbor_tstr_put_term()

Signed-off-by: Øyvind Rønningstad <[email protected]>
@oyvindronningstad @jfischer-no
dfu: Adapt to API changes in zcbor 0.8.x
01013a8 
New arguments in ZCBOR_STATE_D() and zcbor_new_decode_state()

Signed-off-by: Øyvind Rønningstad <[email protected]>
@oyvindronningstad @jfischer-no
modem_attest_token: Adapt to API changes in zcbor 0.8.x
47fa2b0 
new arguments in zcbor_new_state()

Signed-off-by: Øyvind Rønningstad <[email protected]>
@oyvindronningstad @jfischer-no
samples: bluetooth: Adapt to changes in zcbor 0.8.x
f285e70 
zcbor_tstr_put_term()

Signed-off-by: Øyvind Rønningstad <[email protected]>
@oyvindronningstad @jfischer-no
scripts: Update zcbor versions in requirements-*.txt
51b0c43 
Needed to correctly generate code because of naming changes.

Signed-off-by: Øyvind Rønningstad <[email protected]>
@NordicBuilder @jfischer-no
ci: Updating requirements-fixed.txt
6774038 
This is an automated commit from github workflow by NordicBuilder

Signed-off-by: Nordic Builder <[email protected]>
@NordicBuilder NordicBuilder removed the DNM label Feb 20, 2024
@NordicBuilder
ci: Updating requirements-fixed.txt
4a89b61 
This is an automated commit from github workflow by NordicBuilder

Signed-off-by: Nordic Builder <[email protected]>
@jfischer-no jfischer-no merged commit d6b3e24 into nrfconnect:main Feb 20, 2024
35 checks passed
@oyvindronningstad oyvindronningstad deleted the zcbor-0.8.1 branch February 21, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

@plskeggs plskeggs plskeggs approved these changes

@hakonfam hakonfam hakonfam approved these changes

@rlubos rlubos rlubos approved these changes

@gmarull gmarull gmarull approved these changes

@juhaylinen juhaylinen juhaylinen approved these changes

@KAGA164 KAGA164 KAGA164 approved these changes

@umapraseeda umapraseeda umapraseeda approved these changes

@MarkusLassila MarkusLassila MarkusLassila approved these changes

@shanthanordic shanthanordic shanthanordic approved these changes

@sigvartmh sigvartmh Awaiting requested review from sigvartmh

@jayteemo jayteemo Awaiting requested review from jayteemo

@glarsennordic glarsennordic Awaiting requested review from glarsennordic

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic Damian-Nordic is a code owner

@tejlmand tejlmand Awaiting requested review from tejlmand

@grho grho Awaiting requested review from grho

@ihansse ihansse Awaiting requested review from ihansse

@alwa-nordic alwa-nordic Awaiting requested review from alwa-nordic

@carlescufi carlescufi Awaiting requested review from carlescufi

Assignees
No one assigned
Labels
CI-force-downstream doc-required PR must not be merged without tech writer approval. manifest manifest-matter manifest-mcuboot manifest-nrfxlib manifest-sidewalk manifest-zephyr
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.