Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: nrf_modem_lib: Trace support nrf92 #20179

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

anhmolt
Copy link
Contributor

@anhmolt anhmolt commented Feb 4, 2025

Add support for cellular core tracing to nrf_modem_lib library
for nrf92.

@anhmolt anhmolt requested review from a team as code owners February 4, 2025 12:47
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Feb 4, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Feb 4, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 5

Inputs:

Sources:

sdk-nrf: PR head: c18121876e98b359b13e59e1cbfd42a318a304ae

more details

sdk-nrf:

PR head: c18121876e98b359b13e59e1cbfd42a318a304ae
merge base: b1a37c0f7230f3fd7d79bb905f08a59b337ca497
target head (main): b1a37c0f7230f3fd7d79bb905f08a59b337ca497
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (10)
lib
│  ├── nrf_modem_lib
│  │  ├── Kconfig.modemlib
│  │  ├── nrf_modem_lib.c
│  │  │ nrf_modem_os_rpc.c
snippets
│  ├── nrf91-modem-trace-uart
│  │  │ snippet.yml
│  ├── nrf9x-modem-trace-uart
│  │  ├── modem-trace-uart-common.conf
│  │  ├── modem-trace-uart-nrf91.conf
│  │  ├── modem-trace-uart-nrf91.overlay
│  │  ├── modem-trace-uart-nrf92.conf
│  │  ├── modem-trace-uart-nrf92.overlay
│  │  │ snippet.yml

Outputs:

Toolchain

Version: 342151af73
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:342151af73_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 409
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • ✅ test-fw-nrfconnect-nrf-iot_samples
    • ✅ test-fw-nrfconnect-nrf-iot_mosh
    • ⚠️ test-fw-nrfconnect-nrf-iot_cloud
    • ⚠️ test-fw-nrfconnect-nrf-iot_lwm2m
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@anhmolt anhmolt force-pushed the trace-support-nrf92 branch from 16b6187 to 47a004c Compare February 4, 2025 12:57
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

Copy link
Contributor

@eivindj-nordic eivindj-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I wonder if we can do something to link the nrf91-modem-trace-uart snipet to the new nrf9x-modem-trace-uart snippet. We need to keep the old reference as it is used in devzone, devacademy, blogposts etc.

Size calculations for cache flush and invalidate was incorrect
when address was not properly aligned.
Flush and invalidate will now properly flush and invalidate an area
that contains the input area.

Signed-off-by: Andreas Moltumyr <[email protected]>
Add support for cellcore tracing to nrf_modem_lib library
for nrf92.

Signed-off-by: Andreas Moltumyr <[email protected]>
@anhmolt anhmolt force-pushed the trace-support-nrf92 branch from 47a004c to 8058a38 Compare February 5, 2025 09:15
Add new snippet 'nrf9x-modem-trace-uart'. The new snippet can be
used to enable modem tracing over uart for either nrf91 or nrf92
application. It works similar to snippet 'nrf91-modem-trace-uart'.

The 'nrf91-modem-trace-uart' snippet is deprecated, but kept for
backwards compatibility.

Signed-off-by: Andreas Moltumyr <[email protected]>
@anhmolt anhmolt force-pushed the trace-support-nrf92 branch from 8058a38 to c181218 Compare February 5, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants