fix: handleSwitchRouteSet
builds timeline with stale studio routeSets
#1291
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Contributor
This pull request is posted on behalf of the BBC
Type of Contribution
This is a: Bug fix
New Behavior
This fixes a flaw in #1285
My testing showed that it was updating the timeline, and the routeset was toggling, but I didn't notice that the active value for the routeset was always one update behind.
This is because
studioPlayoutModel.switchRouteSet
would store the pending changes on thestudioPlayoutModel
. Then later when building the timeline, it was fetching theDBStudio
off the context. Ignoring that there might be some changes performed earlier in the job that might want to be used.This change changes this, so that the changes are instead stored inside the
context
. This means that after callingswitchRouteSet
any fetches of the studio from thecontext
will reflect the updated but not yet saved values.Testing
Affected areas
Time Frame
Other Information
This also does some refactoring to split up a file. To make review easier, read each commit separately
Status