Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add notes to RundownPlaylist and pipe notes from blueprints from getRundownPlaylistInfo and getShowStyleId #1295

Open
wants to merge 1 commit into
base: release52
Choose a base branch
from

Conversation

Julusian
Copy link
Member

About the Contributor

This pull request is posted on behalf of the BBC

Type of Contribution

This is a: Feature

New Behavior

The 'user notes' produced by the getRundownPlaylistInfo and getShowStyleId blueprint methods were being sent to just the meteor log. This change stores them as notes on the rundownplaylist or rundown, so that they will show up in the ui.
The storing of these notes is stable, as we always use getRundownPlaylistInfo to build a playlist, and we always call getShowStyleId when generating the rundown (except from with adlib-testing rundowns, but these will never use this method), so the notes shouldn't get lost during the normal lifecycle of the playlist/rundown.

If the user logging methods are not called in these blueprint methods, then no difference in behaviour will be observed.

As part of achieving this, a notes property has been added to the playlist, to store some of these notes.

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

This PR affects the ingest logic.

Time Frame

Not urgent, but we would like to get this merged into the in-development release.

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@Julusian Julusian requested a review from a team as a code owner October 21, 2024 14:14
@Julusian Julusian added the Contribution from BBC Contributions sponsored by BBC (bbc.co.uk) label Oct 21, 2024
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 62.96296% with 40 lines in your changes missing coverage. Please review.

Project coverage is 60.64%. Comparing base (ed82e6b) to head (5a498da).
Report is 1 commits behind head on release52.

Files with missing lines Patch % Lines
...ackages/job-worker/src/ingest/generationRundown.ts 51.42% 17 Missing ⚠️
packages/corelib/src/lib.ts 21.42% 11 Missing ⚠️
...worker/src/blueprints/context/StudioUserContext.ts 22.22% 7 Missing ⚠️
packages/job-worker/src/rundownPlaylists.ts 90.69% 4 Missing ⚠️
meteor/server/publications/lib/quickLoop.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           release52    #1295    +/-   ##
===========================================
  Coverage      60.64%   60.64%            
===========================================
  Files            459      459            
  Lines          78583    78645    +62     
  Branches        4902     4915    +13     
===========================================
+ Hits           47654    47695    +41     
+ Misses         30836    30733   -103     
- Partials          93      217   +124     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

… from `getRundownPlaylistInfo` and `getShowStyleId`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution from BBC Contributions sponsored by BBC (bbc.co.uk)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant