feat: add notes
to RundownPlaylist
and pipe notes from blueprints from getRundownPlaylistInfo
and getShowStyleId
#1295
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Contributor
This pull request is posted on behalf of the BBC
Type of Contribution
This is a: Feature
New Behavior
The 'user notes' produced by the
getRundownPlaylistInfo
andgetShowStyleId
blueprint methods were being sent to just the meteor log. This change stores them as notes on the rundownplaylist or rundown, so that they will show up in the ui.The storing of these notes is stable, as we always use
getRundownPlaylistInfo
to build a playlist, and we always callgetShowStyleId
when generating the rundown (except from with adlib-testing rundowns, but these will never use this method), so the notes shouldn't get lost during the normal lifecycle of the playlist/rundown.If the user logging methods are not called in these blueprint methods, then no difference in behaviour will be observed.
As part of achieving this, a
notes
property has been added to the playlist, to store some of these notes.Testing
Affected areas
This PR affects the ingest logic.
Time Frame
Not urgent, but we would like to get this merged into the in-development release.
Other Information
Status