fix: Hold mode doesn't work at all (SOFIE-3661)

[jstarpl]

About the Contributor

This pull request is posted on behalf of the NRK.

Type of Contribution

This is a:

Bug fix

Current Behavior

Hold mode didn't work at all because it would go straight from pending to Completed without modifying the Hold-TO PartInstance. Also, timeline wasn't updated when Hold was being Completed.

New Behavior

The PENDING -> ACTIVE -> COMPLETED cycle is wholly handled inside the take job in job-worker. The misleading code that would switch the Hold state inside cycleSelectedPartInstances has been removed and a new method, resetHoldState has been added to handle the situation of an auto-take happening while Hold is enabled. Inner functions for Hold have been renamed to reflect what they were doing.

Testing

• I have added one or more unit tests for this PR
• I have updated the relevant unit tests
• No unit test changes are needed for this PR

Affected areas

• This PR affects the Hold logic.

Time Frame

• This Bug Fix is critical for us, please review and merge it as soon as possible.

Other Information

Status

• PR is ready to be reviewed.
• The functionality has been tested by the author.
• Relevant unit tests has been added / updated.
• Relevant documentation (code comments, system documentation) has been added / updated.

[codecov]

Codecov Report

Attention: Patch coverage is 75.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 58.00%. Comparing base (d2a3cdf) to head (a7d6999).

Files with missing lines	Patch %	Lines
packages/job-worker/src/playout/take.ts	72.09%	12 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##           release51    #1352      +/-   ##
=============================================
+ Coverage      57.96%   58.00%   +0.04%     
=============================================
  Files            525      525              
  Lines          85164    85165       +1     
  Branches        4428     4451      +23     
=============================================
+ Hits           49362    49403      +41     
+ Misses         35798    35728      -70     
- Partials           4       34      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tsorbo]

This fix has been successfully tested in RK5.