feat(LSG): add buckets topic #1370
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release52 #1370 +/- ##
=============================================
+ Coverage 56.48% 56.86% +0.37%
=============================================
Files 401 392 -9
Lines 72257 71758 -499
Branches 4170 4412 +242
=============================================
- Hits 40816 40804 -12
+ Misses 31204 30816 -388
+ Partials 237 138 -99 ☔ View full report in Codecov by Sentry. |
currently only featuring adLibs and actions valid for all variants (showStyleVariantId === null)
ianshade
force-pushed
the
contribute/EAV-487
branch
from
b8c2709 to
513c048
Compare
nytamin
added
Contribution
| @@ -24,7 +24,7 @@ Currently, there is not a very clearly defined flow for modifying these document | |||
| This includes: | |||
|
|
|||
| - [Blueprints](https://github.com/nrkno/sofie-core/blob/master/packages/corelib/src/dataModel/Blueprint.ts) | |||
| - [Buckets](https://github.com/nrkno/sofie-core/blob/master/meteor/lib/collections/Buckets.ts) | |||
| - [Buckets](https://github.com/nrkno/sofie-core/blob/master/packages/corelib/src/dataModel/Bucket.ts) | |||
There was a problem hiding this comment.
We should probably let this be? This refers to historical information anyway, so will not align with the rest of documentation.
| return { | ||
| id: bucketId, | ||
| name: bucket.name, | ||
| adLibs: [...bucketAdLibs, ...bucketAdLibActions], |
There was a problem hiding this comment.
Should this be sorted according to the _rank of the original objects? I feel like it probably should, considering this is returned as an ordered array? As a Sofie user, I would expect the order to be retained (since I can reorder them in the UI). Especially, since if they aren't sorted, any ordering is gone and there's no way of recovering it. I would expect the users to be using reordering for Bucket organization (keeping the "hottest" clip at the begining or whatever else makes sense in one's workflow). I see that adLibsTopic keeps sorting, so maybe we could use a similar thing here.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
About the Contributor
This pull request is posted on behalf of TV 2 Norge
Type of Contribution
This is a:
Feature
Current Behavior
New Behavior
Buckets with their adLibs and actions are published as an LSG topic. Only adLibs and actions valid for all variants (showStyleVariantId === null) are included, but further contributions are welcome to lift this limitation, should anyone need it.
Testing
Affected areas
This PR affects the Live Status Gateway functionally. In order to achieve that, some types and a publication used by other packages in the core monorepo are moved around, some publications have their parameters changed
Time Frame
Not urgent, but it would be nice to have in release 52
Other Information
These changes were so far tested only on release50, with release51 LSG.This branch also includes changes from #1367. Before that one is merged, and this one is rebased, only all but the oldest commit on this branch are to be reviewed.
Status