Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove comment #1306

Closed
wants to merge 2 commits into from
Closed

Remove comment #1306

wants to merge 2 commits into from

Conversation

alicemacl
Copy link
Contributor

Background

Describe the background for this task, why it emerged and why it must be solved.

Solution

Describe what has been done.

UU checks

  • It is possible to use the keyboard to reach your changes
  • It is possible to enlarge the text 400% without losing functionality
  • It works on both mobile and desktop
  • It works in both Chrome, Safari and Firefox
  • It works with VoiceOver
  • There are no errors in aXe / SiteImprove-plugins / Wave
  • Sanity documentation has been / will be updated (if neccessary)

If no packages, only docs has been changed:

  • Documentation version has been bumped (package.json in docs)

Everything about making a React component:
https://spor.vy.no/guides/how-to-make-new-react-components

HOW TO MAKE A CHANGESET:
Go here: https://spor.vy.no/guides/how-to-make-new-react-components#creating-a-pr-and-publish-package

How to test

Desribe how code reviewer may test your solution (what page, expected result).

Screenshots

Before After

@alicemacl alicemacl requested review from ithen15 and a team as code owners November 18, 2024 08:45
Copy link

changeset-bot bot commented Nov 18, 2024

🦋 Changeset detected

Latest commit: 3b397c3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@vygruppen/spor-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alicemacl
Copy link
Contributor Author

This was just a demo to show how to publish a new package.

@alicemacl alicemacl closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant