Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aria attributes to introduce the skeleotons component #1314

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

cibietici
Copy link
Contributor

Background

Skeletons component, even if it is handle as not focusable element, had not aria attributes to introduce the component to screen readers

Solution

It may looks overkill since the component is not focusable but to ensure all screenreader avoid consider this element adding these attributes will help

UU checks

  • It is possible to use the keyboard to reach your changes
  • It is possible to enlarge the text 400% without losing functionality
  • It works on both mobile and desktop
  • It works in both Chrome, Safari and Firefox
  • It works with VoiceOver
  • There are no errors in aXe / SiteImprove-plugins / Wave
  • Sanity documentation has been / will be updated (if neccessary)

If no packages, only docs has been changed:

  • Documentation version has been bumped (package.json in docs)

Everything about making a React component:
https://spor.vy.no/guides/how-to-make-new-react-components

HOW TO MAKE A CHANGESET:
Go here: https://spor.vy.no/guides/how-to-make-new-react-components#creating-a-pr-and-publish-package

How to test

Run application locally and check http://localhost:3000/components/skeletons

@cibietici cibietici self-assigned this Nov 20, 2024
@cibietici cibietici requested review from ithen15 and a team as code owners November 20, 2024 08:58
Copy link

changeset-bot bot commented Nov 20, 2024

🦋 Changeset detected

Latest commit: 6b0085a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@vygruppen/spor-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cibietici cibietici merged commit f87a8f7 into main Nov 20, 2024
2 checks passed
@cibietici cibietici deleted the skeletons-aria branch November 20, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants