Bump version of spor-icon-elm in spor-elm #777
Conversation
|
ReyhanAZ
requested review from
heisand,
selbekk,
a team,
FluidSense and
SimenRenberg
| Critical -> | ||
| feedbackIcon Icon.Error | ||
|
|
||
| Major -> | ||
| warningFill18x18 | ||
| Major -> | ||
| feedbackIcon Icon.Warning | ||
|
|
||
| Minor -> | ||
| warningFill18x18 | ||
| Minor -> | ||
| feedbackIcon Icon.Warning | ||
|
|
||
| Info -> | ||
| Svg.fromUnstyled <| Feedback.informationFill18X18 [] | ||
| Info -> | ||
| feedbackIcon Icon.Information |
There was a problem hiding this comment.
Her kan vi fjerne feedbackIcon fra alle casene og heller sette foran case-statementen. E.g.
feedbackIcon <| case deviationLevel of
...| ( LocalTrain, Sm ) -> | ||
| Transportation.trainFill18X18 [] | ||
| trainIcon Icon.Size18 | ||
|
|
||
| ( LocalTrain, Md ) -> | ||
| Transportation.trainFill24X24 [] | ||
| trainIcon Icon.Size24 | ||
|
|
||
| ( LocalTrain, Lg ) -> | ||
| Transportation.trainFill30X30 [] | ||
| trainIcon Icon.Size30 |
There was a problem hiding this comment.
Hva med å lage en sizeToIconSize i let...in, så kan man i stedet si
( LocalTrain, size_ ) ->
trainIcon <| sizeToIconSize size_
( RegionTrain, size_ ) ->
trainIcon <| sizeToIconSize size_
osv..? 😄
There was a problem hiding this comment.
Hvis et case også har unikt ikon for sin variant kan egentlig ikonfunksjone bare ligge i den casen også!
Background
Need to bump the version of
spor-icon-elmintravel-costumize, but this has a dependency onspor-elmwhich uses the old version.Solution
Bumped to newer version. Changed the files that needed to be altered.