Block notifications #3805
Merged
Block notifications #3805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new RPC method to retrieve block notifications organized by trigger type. Signed-off-by: Ricardo Prado <[email protected]> Signed-off-by: Roman Khimov <[email protected]>
Unknown fields are not allowed. Signed-off-by: Roman Khimov <[email protected]>
Ignoring them is not correct. Notice that block-level aers are always present and if filtering returns nothing the value of the resulting slice still remains nil, so the behavior is the same. Signed-off-by: Roman Khimov <[email protected]>
Signed-off-by: Roman Khimov <[email protected]>
Be more consistent. Signed-off-by: Roman Khimov <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3805 +/- ##
=======================================
Coverage 82.82% 82.82%
=======================================
Files 337 338 +1
Lines 47351 47434 +83
=======================================
+ Hits 39219 39288 +69
- Misses 6522 6535 +13
- Partials 1610 1611 +1 ☔ View full report in Codecov by Sentry. |
AliceInHunterland
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3779. Incorporates and replaces #3781.