ARP boundary check

ntop · Feb 28, 2025 · d758a2e · d758a2e
1 parent 4106ccc
commit d758a2e
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/NetworkInterface.cpp b/src/NetworkInterface.cpp
@@ -3275,8 +3275,8 @@ bool NetworkInterface::dissectPacket(int32_t if_index,
     if (dstMac) dstMac->incRcvdStats(h->ts.tv_sec, 1, len_on_wire);
 #endif
 
-    if ((eth_type == ETHERTYPE_ARP) &&
-	(h->caplen >= (sizeof(arp_header) + sizeof(struct ndpi_ethhdr)))) {
+    if ((eth_type == ETHERTYPE_ARP)
+	&& (h->caplen >= (ip_offset + sizeof(arp_header)))) {
       struct arp_header *arpp = (struct arp_header *)&packet[ip_offset];
       u_int16_t arp_opcode = ntohs(arpp->ar_op);